Fixes use-after-free bug in QUIC.

Fixes use-after-free bug in QUIC.

QuicSession destructor ends up calling the QuicSpdyStream destructor, which in turn tries to access a QuicSession method via a non-owning pointer back to the session. This CL arranges for the non-owning pointer to be set to null before QuicSpdyStream destructor is called.

Merge Internal CL: 120973813

Creates a MockQuicSession for use in ReliableQuicStreamTest, which currently incorrectly uses a MockQuicSpdySession.

The test class being fixed in this CL uses a MockQuicSpdySession, which is a QuicSpdySession, with TestStreams, which are ReliableQuicStreams. Bad things can happen since QuicSpdySession seems to freely assume that its streams are QuicSpdyStreams. Bad things do happen, but they inexplicably seem to show up only in Chromium tests.

Merge Internal CL: 120989117

BUG=605474
Committed: https://crrev.com/4ee9d76953f16811186942971822cf12d48db7ae
Cr-Commit-Position: refs/heads/master@{#390575}

[Jana, 2016-04-28 06:41:55]

Description was changed from

==========
Fixes use-after-free bug in QUIC.

QuicSession destructor ends up calling the QuicSpdyStream destructor, which
in turn tries to access a QuicSession method via a non-owning pointer back
to the session. This CL arranges for the non-owning pointer to be set to null
before QuicSpdyStream destructor is called.

BUG=605474
==========

to

==========
Fixes use-after-free bug in QUIC.

QuicSession destructor ends up calling the QuicSpdyStream destructor, which
in turn tries to access a QuicSession method via a non-owning pointer back
to the session. This CL arranges for the non-owning pointer to be set to null
before QuicSpdyStream destructor is called.

BUG=605474
==========

[Jana, 2016-04-28 06:41:55]

jri@chromium.org changed reviewers:
+ rch@chromium.org

[Jana, 2016-04-28 06:42:51]

Ryan, PTAL.

[Ryan Hamilton, 2016-04-28 19:04:00]

lgtm, but please include the internal CL numbers in the CL description

[Jana, 2016-04-29 01:01:10]

Description was changed from

==========
Fixes use-after-free bug in QUIC.

QuicSession destructor ends up calling the QuicSpdyStream destructor, which
in turn tries to access a QuicSession method via a non-owning pointer back
to the session. This CL arranges for the non-owning pointer to be set to null
before QuicSpdyStream destructor is called.

BUG=605474
==========

to

==========
Fixes use-after-free bug in QUIC.

QuicSession destructor ends up calling the QuicSpdyStream destructor, which in
turn tries to access a QuicSession method via a non-owning pointer back to the
session. This CL arranges for the non-owning pointer to be set to null before
QuicSpdyStream destructor is called.

Merge internal CL: 120973813

Creates a MockQuicSession for use in ReliableQuicStreamTest, which currently
incorrectly uses a MockQuicSpdySession.

The test class being fixed in this CL uses a MockQuicSpdySession, which is a
QuicSpdySession, with TestStreams, which are ReliableQuicStreams. Bad things can
happen since QuicSpdySession seems to freely assume that its streams are
QuicSpdyStreams. Bad things do happen, but they inexplicably seem to show up
only in Chromium tests.

Merge Internal CL: 120989117

BUG=605474
==========

[Jana, 2016-04-29 01:01:30]

Description was changed from

==========
Fixes use-after-free bug in QUIC.

QuicSession destructor ends up calling the QuicSpdyStream destructor, which in
turn tries to access a QuicSession method via a non-owning pointer back to the
session. This CL arranges for the non-owning pointer to be set to null before
QuicSpdyStream destructor is called.

Merge internal CL: 120973813

Creates a MockQuicSession for use in ReliableQuicStreamTest, which currently
incorrectly uses a MockQuicSpdySession.

The test class being fixed in this CL uses a MockQuicSpdySession, which is a
QuicSpdySession, with TestStreams, which are ReliableQuicStreams. Bad things can
happen since QuicSpdySession seems to freely assume that its streams are
QuicSpdyStreams. Bad things do happen, but they inexplicably seem to show up
only in Chromium tests.

Merge Internal CL: 120989117

BUG=605474
==========

to

==========
Fixes use-after-free bug in QUIC.

QuicSession destructor ends up calling the QuicSpdyStream destructor, which in
turn tries to access a QuicSession method via a non-owning pointer back to the
session. This CL arranges for the non-owning pointer to be set to null before
QuicSpdyStream destructor is called.

Merge Internal CL: 120973813

Creates a MockQuicSession for use in ReliableQuicStreamTest, which currently
incorrectly uses a MockQuicSpdySession.

The test class being fixed in this CL uses a MockQuicSpdySession, which is a
QuicSpdySession, with TestStreams, which are ReliableQuicStreams. Bad things can
happen since QuicSpdySession seems to freely assume that its streams are
QuicSpdyStreams. Bad things do happen, but they inexplicably seem to show up
only in Chromium tests.

Merge Internal CL: 120989117

BUG=605474
==========

[Jana, 2016-04-29 01:01:54]

The CQ bit was checked by jri@chromium.org

[commit-bot: I haz the power, 2016-04-29 01:03:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932653002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932653002/1

[commit-bot: I haz the power, 2016-04-29 02:04:44]

Description was changed from

==========
Fixes use-after-free bug in QUIC.

QuicSession destructor ends up calling the QuicSpdyStream destructor, which in
turn tries to access a QuicSession method via a non-owning pointer back to the
session. This CL arranges for the non-owning pointer to be set to null before
QuicSpdyStream destructor is called.

Merge Internal CL: 120973813

Creates a MockQuicSession for use in ReliableQuicStreamTest, which currently
incorrectly uses a MockQuicSpdySession.

The test class being fixed in this CL uses a MockQuicSpdySession, which is a
QuicSpdySession, with TestStreams, which are ReliableQuicStreams. Bad things can
happen since QuicSpdySession seems to freely assume that its streams are
QuicSpdyStreams. Bad things do happen, but they inexplicably seem to show up
only in Chromium tests.

Merge Internal CL: 120989117

BUG=605474
==========

to

==========
Fixes use-after-free bug in QUIC.

QuicSession destructor ends up calling the QuicSpdyStream destructor, which in
turn tries to access a QuicSession method via a non-owning pointer back to the
session. This CL arranges for the non-owning pointer to be set to null before
QuicSpdyStream destructor is called.

Merge Internal CL: 120973813

Creates a MockQuicSession for use in ReliableQuicStreamTest, which currently
incorrectly uses a MockQuicSpdySession.

The test class being fixed in this CL uses a MockQuicSpdySession, which is a
QuicSpdySession, with TestStreams, which are ReliableQuicStreams. Bad things can
happen since QuicSpdySession seems to freely assume that its streams are
QuicSpdyStreams. Bad things do happen, but they inexplicably seem to show up
only in Chromium tests.

Merge Internal CL: 120989117

BUG=605474
==========

[commit-bot: I haz the power, 2016-04-29 02:04:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-30 17:23:50]

Patchset 1 (id:??) landed as
https://crrev.com/4ee9d76953f16811186942971822cf12d48db7ae
Cr-Commit-Position: refs/heads/master@{#390575}

[commit-bot: I haz the power, 2016-04-30 17:59:05]

Description was changed from

==========
Fixes use-after-free bug in QUIC.

QuicSession destructor ends up calling the QuicSpdyStream destructor, which in
turn tries to access a QuicSession method via a non-owning pointer back to the
session. This CL arranges for the non-owning pointer to be set to null before
QuicSpdyStream destructor is called.

Merge Internal CL: 120973813

Creates a MockQuicSession for use in ReliableQuicStreamTest, which currently
incorrectly uses a MockQuicSpdySession.

The test class being fixed in this CL uses a MockQuicSpdySession, which is a
QuicSpdySession, with TestStreams, which are ReliableQuicStreams. Bad things can
happen since QuicSpdySession seems to freely assume that its streams are
QuicSpdyStreams. Bad things do happen, but they inexplicably seem to show up
only in Chromium tests.

Merge Internal CL: 120989117

BUG=605474
==========

to

==========
Fixes use-after-free bug in QUIC.

QuicSession destructor ends up calling the QuicSpdyStream destructor, which in
turn tries to access a QuicSession method via a non-owning pointer back to the
session. This CL arranges for the non-owning pointer to be set to null before
QuicSpdyStream destructor is called.

Merge Internal CL: 120973813

Creates a MockQuicSession for use in ReliableQuicStreamTest, which currently
incorrectly uses a MockQuicSpdySession.

The test class being fixed in this CL uses a MockQuicSpdySession, which is a
QuicSpdySession, with TestStreams, which are ReliableQuicStreams. Bad things can
happen since QuicSpdySession seems to freely assume that its streams are
QuicSpdyStreams. Bad things do happen, but they inexplicably seem to show up
only in Chromium tests.

Merge Internal CL: 120989117

BUG=605474

Committed: https://crrev.com/4ee9d76953f16811186942971822cf12d48db7ae
Cr-Commit-Position: refs/heads/master@{#390575}
==========