Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: net/quic/reliable_quic_stream_test.cc

Issue 1932653002: Fixes use-after-free bug in QUIC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_spdy_stream.cc ('k') | net/quic/test_tools/quic_session_peer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/reliable_quic_stream_test.cc
diff --git a/net/quic/reliable_quic_stream_test.cc b/net/quic/reliable_quic_stream_test.cc
index 645573fbd71d38b7ffad85e2abc656503acb2b28..2aefc230f5cd603dbc8fbc47109cc299c6455938 100644
--- a/net/quic/reliable_quic_stream_test.cc
+++ b/net/quic/reliable_quic_stream_test.cc
@@ -107,7 +107,7 @@ class ReliableQuicStreamTest : public ::testing::TestWithParam<bool> {
void Initialize(bool stream_should_process_data) {
connection_ = new StrictMock<MockConnection>(
&helper_, &alarm_factory_, Perspective::IS_SERVER, supported_versions_);
- session_.reset(new StrictMock<MockQuicSpdySession>(connection_));
+ session_.reset(new StrictMock<MockQuicSession>(connection_));
// New streams rely on having the peer's flow control receive window
// negotiated in the config.
@@ -152,7 +152,7 @@ class ReliableQuicStreamTest : public ::testing::TestWithParam<bool> {
MockConnectionHelper helper_;
MockAlarmFactory alarm_factory_;
MockConnection* connection_;
- std::unique_ptr<MockQuicSpdySession> session_;
+ std::unique_ptr<MockQuicSession> session_;
TestStream* stream_;
SpdyHeaderBlock headers_;
QuicWriteBlockedList* write_blocked_list_;
@@ -648,7 +648,7 @@ TEST_F(ReliableQuicStreamTest, EarlyResponseFinHandling) {
Initialize(kShouldProcessData);
EXPECT_CALL(*connection_, CloseConnection(_, _, _)).Times(0);
EXPECT_CALL(*session_, WritevData(_, _, _, _, _))
- .WillRepeatedly(Invoke(MockQuicSpdySession::ConsumeAllData));
+ .WillRepeatedly(Invoke(MockQuicSession::ConsumeAllData));
// Receive data for the request.
QuicStreamFrame frame1(stream_->id(), false, 0, StringPiece("Start"));
« no previous file with comments | « net/quic/quic_spdy_stream.cc ('k') | net/quic/test_tools/quic_session_peer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698