net/quic/quic_session_test.cc - Issue 1932653002: Fixes use-after-free bug in QUIC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_session_test.cc

Issue 1932653002: Fixes use-after-free bug in QUIC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_session_test.cc

diff --git a/net/quic/quic_session_test.cc b/net/quic/quic_session_test.cc

index 770b15dc8924be519ec1037a21475591ea31bf14..37c73c2f2c5c649e1aa8a0b594474ade35ba7ac6 100644

--- a/net/quic/quic_session_test.cc

+++ b/net/quic/quic_session_test.cc

@@ -1164,7 +1164,7 @@ TEST_P(QuicSessionTestClient, RecordFinAfterReadSideClosed) {

session_.PostProcessAfterData();

EXPECT_TRUE(connection_->connected());

EXPECT_TRUE(QuicSessionPeer::IsStreamClosed(&session_, stream_id));

- EXPECT_EQ(nullptr, QuicSessionPeer::dynamic_streams(&session_)[stream_id]);

+ EXPECT_FALSE(QuicSessionPeer::IsStreamCreated(&session_, stream_id));

// The stream is not waiting for the arrival of the peer's final offset as it

// was received with the FIN earlier.

« no previous file with comments | « no previous file | net/quic/quic_spdy_session.cc » ('j') | no next file with comments »