Handle rrects with one circular corner and three square corners in GrRRectEffect.

Handle rrects with one circular corner and three square corners in GrRRectEffect.

BUG=skia:2181
Committed: http://code.google.com/p/skia/source/detail?r=13739

[jvanverth1, 2014-03-11 14:53:23]

LGTM, just one comment:

https://codereview.chromium.org/193263002/diff/20001/src/gpu/effects/GrRRectE...
File src/gpu/effects/GrRRectEffect.cpp (right):

https://codereview.chromium.org/193263002/diff/20001/src/gpu/effects/GrRRectE...
src/gpu/effects/GrRRectEffect.cpp:215: fragmentPos, rectName, rectName,
fragmentPos);
I suppose it doesn't matter because you're taking the length of dxy, but I found
it confusing that you have x - right and top - y. I'd expect right-x and top-y
(assuming y up).

[bsalomon, 2014-03-11 15:11:03]

https://codereview.chromium.org/193263002/diff/20001/src/gpu/effects/GrRRectE...
File src/gpu/effects/GrRRectEffect.cpp (right):

https://codereview.chromium.org/193263002/diff/20001/src/gpu/effects/GrRRectE...
src/gpu/effects/GrRRectEffect.cpp:215: fragmentPos, rectName, rectName,
fragmentPos);
On 2014/03/11 14:53:23, JimVV wrote:
> I suppose it doesn't matter because you're taking the length of dxy, but I
found
> it confusing that you have x - right and top - y. I'd expect right-x and top-y
> (assuming y up).

Yup, it's a bit weird. It's done that way so that for each corner dxy is >= 0 if
the frag is in the relevant quadrant. It allows max(dxy, 0) to clamp out the
interior for all the (non-square) corners.

[bsalomon, 2014-03-11 15:11:08]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-03-11 15:11:10]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/193263002/20001

[commit-bot: I haz the power, 2014-03-11 15:18:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-11 15:18:02]

Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s)
BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools
http://108.170.219.164:10117/buildstatus?builder=Build-Mac10.8-Clang-x86-Rele...

[bsalomon, 2014-03-11 15:29:19]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-03-11 15:29:33]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/193263002/40001

[commit-bot: I haz the power, 2014-03-11 15:54:57]

Change committed as 13739