Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1932163002: Reland of move more dead code after Object.observe removal (Closed)

Created:
4 years, 7 months ago by Jakob Kummerow
Modified:
4 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, adamk
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Remove more dead code after Object.observe removal (patchset #1 id:1 of https://codereview.chromium.org/1929293002/ ) This moves __{define,lookup}{Getter,Setter}__ to builtins.cc. Compared to the first attempt, this patch now preserves non-spec-compliant legacy behavior and does not throw on failure. Original review: https://codereview.chromium.org/1904313004 Committed: https://crrev.com/1095835a61ae0b35d69f26aa59f76fa0a6ee96a9 Cr-Commit-Position: refs/heads/master@{#35899}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : don't throw on error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -439 lines) Patch
M src/api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/builtins.h View 1 2 chunks +8 lines, -4 lines 0 comments Download
M src/builtins.cc View 1 2 2 chunks +129 lines, -6 lines 0 comments Download
M src/contexts.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/debug/debug.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/isolate-inl.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/js/array.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/js/macros.py View 1 2 chunks +0 lines, -11 lines 0 comments Download
M src/js/prologue.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/js/v8natives.js View 1 4 chunks +4 lines, -52 lines 0 comments Download
M src/objects.h View 1 5 chunks +8 lines, -23 lines 0 comments Download
M src/objects.cc View 1 6 chunks +14 lines, -219 lines 0 comments Download
M src/runtime/runtime.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 chunks +0 lines, -103 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Jakob Kummerow
Created Reland of move more dead code after Object.observe removal
4 years, 7 months ago (2016-04-29 07:35:45 UTC) #1
Jakob Kummerow
As discussed, PTAL. The delta since the first attempt is in patch sets 2 -> ...
4 years, 7 months ago (2016-04-29 09:46:49 UTC) #6
Toon Verwaest
lgtm
4 years, 7 months ago (2016-04-29 09:48:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932163002/320001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932163002/320001
4 years, 7 months ago (2016-04-29 09:49:04 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:320001)
4 years, 7 months ago (2016-04-29 10:14:47 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:36 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1095835a61ae0b35d69f26aa59f76fa0a6ee96a9
Cr-Commit-Position: refs/heads/master@{#35899}

Powered by Google App Engine
This is Rietveld 408576698