Remove more dead code after Object.observe removal

Remove more dead code after Object.observe removal

This moves __{define,lookup}{Getter,Setter}__ to builtins.cc to free up the JavaScript implementation of DefineOwnProperty for deletion.

Committed: https://crrev.com/15e106382e679fb852b966eddc64d518c0a084ed
Cr-Commit-Position: refs/heads/master@{#35876}

[Jakob Kummerow, 2016-04-22 13:55:09]

jkummerow@chromium.org changed reviewers:
+ verwaest@chromium.org

[Jakob Kummerow, 2016-04-22 13:55:09]

review comments below.

https://codereview.chromium.org/1904313004/diff/20001/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1904313004/diff/20001/src/builtins.cc#newcode...
src/builtins.cc:1791: ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, object,
assign to new "Handle<JSReceiver> receiver"

https://codereview.chromium.org/1904313004/diff/20001/src/builtins.cc#newcode...
src/builtins.cc:1833: // 3. TODO
yep, TODO :-)

[Jakob Kummerow, 2016-04-22 14:04:54]

https://codereview.chromium.org/1904313004/diff/20001/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1904313004/diff/20001/src/builtins.cc#newcode...
src/builtins.cc:1791: ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, object,
On 2016/04/22 13:55:09, Jakob wrote:
> assign to new "Handle<JSReceiver> receiver"

Done.

https://codereview.chromium.org/1904313004/diff/20001/src/builtins.cc#newcode...
src/builtins.cc:1833: // 3. TODO
On 2016/04/22 13:55:09, Jakob wrote:
> yep, TODO :-)

Dropped (we're not implementing the spec exactly, but it's deprecated Annex B
stuff anyway, so probably not worth fixing).

[Toon Verwaest, 2016-04-22 14:05:25]

lgtm

[Jakob Kummerow, 2016-04-22 14:06:19]

Description was changed from

==========
Remove more dead code after Object.observe removal

This moves __defineGetter__/__defineSetter__ to builtins.cc to free up
the JavaScript implementation of DefineOwnProperty for deletion.
==========

to

==========
Remove more dead code after Object.observe removal

This moves __{define,lookup}{Getter,Setter}__ to builtins.cc to free up the
JavaScript implementation of DefineOwnProperty for deletion.
==========

[Jakob Kummerow, 2016-04-22 14:06:23]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2016-04-22 14:06:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904313004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904313004/40001

[commit-bot: I haz the power, 2016-04-22 14:25:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 14:25:36]

Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm64_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng_trigg...)

[Jakob Kummerow, 2016-04-28 18:06:13]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2016-04-28 18:06:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1904313004/#ps80001
(title: "mark outdated mozilla tests as FAIL")

[commit-bot: I haz the power, 2016-04-28 18:06:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904313004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904313004/80001

[commit-bot: I haz the power, 2016-04-28 18:34:25]

Description was changed from

==========
Remove more dead code after Object.observe removal

This moves __{define,lookup}{Getter,Setter}__ to builtins.cc to free up the
JavaScript implementation of DefineOwnProperty for deletion.
==========

to

==========
Remove more dead code after Object.observe removal

This moves __{define,lookup}{Getter,Setter}__ to builtins.cc to free up the
JavaScript implementation of DefineOwnProperty for deletion.
==========

[commit-bot: I haz the power, 2016-04-28 18:34:26]

Committed patchset #5 (id:80001)

[Michael Achenbach, 2016-04-29 06:28:36]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1929293002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Looks like this breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

[commit-bot: I haz the power, 2016-05-01 22:02:51]

Description was changed from

==========
Remove more dead code after Object.observe removal

This moves __{define,lookup}{Getter,Setter}__ to builtins.cc to free up the
JavaScript implementation of DefineOwnProperty for deletion.
==========

to

==========
Remove more dead code after Object.observe removal

This moves __{define,lookup}{Getter,Setter}__ to builtins.cc to free up the
JavaScript implementation of DefineOwnProperty for deletion.

Committed: https://crrev.com/15e106382e679fb852b966eddc64d518c0a084ed
Cr-Commit-Position: refs/heads/master@{#35876}
==========

[commit-bot: I haz the power, 2016-05-01 22:02:53]

Patchset 5 (id:??) landed as
https://crrev.com/15e106382e679fb852b966eddc64d518c0a084ed
Cr-Commit-Position: refs/heads/master@{#35876}