Issue 193193002: plumbing for GPU fast blur

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193193002: plumbing for GPU fast blur (Closed)

Created:
6 years, 9 months ago by humper

Modified:
6 years, 9 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@fast_rrect_blur_cpu_plumb

Visibility:
Public.

More Reviews

Description

plumbing for GPU fast blur BUG=skia:2281 Committed: http://code.google.com/p/skia/source/detail?r=13735

Patch Set 2 : fix indentation issue #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -8 lines)			Patch
M	include/core/SkMaskFilter.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	include/core/SkRRect.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkMaskFilter.cpp	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/core/SkRRect.cpp	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/effects/SkBlurMaskFilter.cpp	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1	4 chunks	+42 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bsalomon

Other than the if on its own line lgtm. https://codereview.chromium.org/193193002/diff/1/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/193193002/diff/1/src/gpu/SkGpuDevice.cpp#newcode1010 src/gpu/SkGpuDevice.cpp:1010: ...

6 years, 9 months ago (2014-03-10 20:41:47 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/193193002/20001

6 years, 9 months ago (2014-03-10 21:50:56 UTC) #4

Message was sent while issue was closed.

Change committed as 13735

Expand Messages | Collapse Messages

Issue 193193002: plumbing for GPU fast blur (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix indentation issue #

Messages