Simplify SVG layout attribute reordering

Simplify SVG layout attribute reordering

findFirstAndLastAttributesInVector is an identity transform, since it
only search for first/lastContext in the layout attributes vector and
return that in the out variable. Remove it. This in turn means that the
vector of layout attributes is unused, and hence also removed. Finally
tidy up the reversing loop by moving more code into the swapping helper
function, and merge the two identical sequences of item swapping code.
Drop the ASSERT that disallows having no (nullptr) user-data for the
closure to collectLeafBoxesInLogicalOrder.

BUG=607906
Committed: https://crrev.com/23b6e12f968b96fa35d612b0779144fb62a1cf86
Cr-Commit-Position: refs/heads/master@{#390751}

[fs, 2016-04-29 12:53:41]

Description was changed from

==========
Simplify attribute reordering

BUG=
==========

to

==========
Simplify SVG layout attribute reordering

findFirstAndLastAttributesInVector is an identity transform, since it
only search for first/lastContext in the layout attributes vector and
return that in the out variable. Remove it. This in turn means that the
vector of layout attributes is unused, and hence also removed. Finally
tidy up the reversing loop by moving more code into the swapping helper
function, and merge the two identical sequences of item swapping code.

BUG=
==========

[fs, 2016-04-29 13:25:21]

Description was changed from

==========
Simplify SVG layout attribute reordering

findFirstAndLastAttributesInVector is an identity transform, since it
only search for first/lastContext in the layout attributes vector and
return that in the out variable. Remove it. This in turn means that the
vector of layout attributes is unused, and hence also removed. Finally
tidy up the reversing loop by moving more code into the swapping helper
function, and merge the two identical sequences of item swapping code.

BUG=
==========

to

==========
Simplify SVG layout attribute reordering

findFirstAndLastAttributesInVector is an identity transform, since it
only search for first/lastContext in the layout attributes vector and
return that in the out variable. Remove it. This in turn means that the
vector of layout attributes is unused, and hence also removed. Finally
tidy up the reversing loop by moving more code into the swapping helper
function, and merge the two identical sequences of item swapping code.

BUG=607906
==========

[fs, 2016-04-29 13:43:18]

Description was changed from

==========
Simplify SVG layout attribute reordering

findFirstAndLastAttributesInVector is an identity transform, since it
only search for first/lastContext in the layout attributes vector and
return that in the out variable. Remove it. This in turn means that the
vector of layout attributes is unused, and hence also removed. Finally
tidy up the reversing loop by moving more code into the swapping helper
function, and merge the two identical sequences of item swapping code.

BUG=607906
==========

to

==========
Simplify SVG layout attribute reordering

findFirstAndLastAttributesInVector is an identity transform, since it
only search for first/lastContext in the layout attributes vector and
return that in the out variable. Remove it. This in turn means that the
vector of layout attributes is unused, and hence also removed. Finally
tidy up the reversing loop by moving more code into the swapping helper
function, and merge the two identical sequences of item swapping code.
Drop the ASSERT that disallows having a null (no) user-data for the
closure to.

BUG=607906
==========

[fs, 2016-04-29 13:43:38]

Description was changed from

==========
Simplify SVG layout attribute reordering

findFirstAndLastAttributesInVector is an identity transform, since it
only search for first/lastContext in the layout attributes vector and
return that in the out variable. Remove it. This in turn means that the
vector of layout attributes is unused, and hence also removed. Finally
tidy up the reversing loop by moving more code into the swapping helper
function, and merge the two identical sequences of item swapping code.
Drop the ASSERT that disallows having a null (no) user-data for the
closure to.

BUG=607906
==========

to

==========
Simplify SVG layout attribute reordering

findFirstAndLastAttributesInVector is an identity transform, since it
only search for first/lastContext in the layout attributes vector and
return that in the out variable. Remove it. This in turn means that the
vector of layout attributes is unused, and hence also removed. Finally
tidy up the reversing loop by moving more code into the swapping helper
function, and merge the two identical sequences of item swapping code.
Drop the ASSERT that disallows having a null (no) user-data for the
closure to collectLeafBoxesInLogicalOrder.

BUG=607906
==========

[fs, 2016-04-29 13:44:01]

Description was changed from

==========
Simplify SVG layout attribute reordering

findFirstAndLastAttributesInVector is an identity transform, since it
only search for first/lastContext in the layout attributes vector and
return that in the out variable. Remove it. This in turn means that the
vector of layout attributes is unused, and hence also removed. Finally
tidy up the reversing loop by moving more code into the swapping helper
function, and merge the two identical sequences of item swapping code.
Drop the ASSERT that disallows having a null (no) user-data for the
closure to collectLeafBoxesInLogicalOrder.

BUG=607906
==========

to

==========
Simplify SVG layout attribute reordering

findFirstAndLastAttributesInVector is an identity transform, since it
only search for first/lastContext in the layout attributes vector and
return that in the out variable. Remove it. This in turn means that the
vector of layout attributes is unused, and hence also removed. Finally
tidy up the reversing loop by moving more code into the swapping helper
function, and merge the two identical sequences of item swapping code.
Drop the ASSERT that disallows having no (nullptr) user-data for the
closure to collectLeafBoxesInLogicalOrder.

BUG=607906
==========

[fs, 2016-04-29 14:32:55]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, schenney@chromium.org

[Stephen Chennney, 2016-04-29 18:05:19]

https://codereview.chromium.org/1931303002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp (right):

https://codereview.chromium.org/1931303002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp:1283:
(*customReverseImplementation)(userData, first, last);
Do we document the fact that userData may be null in this callback method, in
the place we declare the CustomInlineBoxRangeReverse type? If not, we should.

Is userData even needed at all now?

[fs, 2016-04-29 18:44:16]

https://codereview.chromium.org/1931303002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp (right):

https://codereview.chromium.org/1931303002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp:1283:
(*customReverseImplementation)(userData, first, last);
On 2016/04/29 at 18:05:19, Stephen Chennney wrote:
> Do we document the fact that userData may be null in this callback method, in
the place we declare the CustomInlineBoxRangeReverse type? If not, we should.
> 
> Is userData even needed at all now?

It's dead AFAIK. reorderValueLists is the only thing that uses the
callback/closure, and I hope to be able to get rid of it there as well. Removed
userData.

[Stephen Chennney, 2016-04-29 20:14:30]

lgtm. I presume the iOS GN bots are FYI only, and not commit blocking. You
haven't added/removed any files and we don't even use Blink on iOS.

[fs, 2016-04-29 20:47:19]

On 2016/04/29 at 20:14:30, schenney wrote:
> lgtm. I presume the iOS GN bots are FYI only, and not commit blocking. You
haven't added/removed any files and we don't even use Blink on iOS.

Yeah they look unrelated. (Almost looks like those bots were renamed/retired.)

[fs, 2016-04-29 20:49:35]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-04-29 20:49:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931303002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931303002/40001

[commit-bot: I haz the power, 2016-04-29 20:54:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:28:42]

Patchset 3 (id:??) landed as
https://crrev.com/23b6e12f968b96fa35d612b0779144fb62a1cf86
Cr-Commit-Position: refs/heads/master@{#390751}

[commit-bot: I haz the power, 2016-04-30 18:02:27]

Description was changed from

==========
Simplify SVG layout attribute reordering

findFirstAndLastAttributesInVector is an identity transform, since it
only search for first/lastContext in the layout attributes vector and
return that in the out variable. Remove it. This in turn means that the
vector of layout attributes is unused, and hence also removed. Finally
tidy up the reversing loop by moving more code into the swapping helper
function, and merge the two identical sequences of item swapping code.
Drop the ASSERT that disallows having no (nullptr) user-data for the
closure to collectLeafBoxesInLogicalOrder.

BUG=607906
==========

to

==========
Simplify SVG layout attribute reordering

findFirstAndLastAttributesInVector is an identity transform, since it
only search for first/lastContext in the layout attributes vector and
return that in the out variable. Remove it. This in turn means that the
vector of layout attributes is unused, and hence also removed. Finally
tidy up the reversing loop by moving more code into the swapping helper
function, and merge the two identical sequences of item swapping code.
Drop the ASSERT that disallows having no (nullptr) user-data for the
closure to collectLeafBoxesInLogicalOrder.

BUG=607906

Committed: https://crrev.com/23b6e12f968b96fa35d612b0779144fb62a1cf86
Cr-Commit-Position: refs/heads/master@{#390751}
==========