third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h - Issue 1931303002: Simplify SVG layout attribute reordering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h

Issue 1931303002: Simplify SVG layout attribute reordering (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove userData argument/closure. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp ('k') | third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h

diff --git a/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h b/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h

index 1b73d0ad626ed318493377103c2fe87311e5893b..338ff7cdad6edf5e8b518771cc3bf8f734ab227d 100644

--- a/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h

+++ b/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h

@@ -25,7 +25,6 @@

#include "core/layout/api/LineLayoutBlockFlow.h"

#include "core/layout/line/RootInlineBox.h"

-#include "core/layout/svg/SVGTextLayoutEngine.h"

namespace blink {

@@ -53,7 +52,7 @@ public:

bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom) final;

private:

- void reorderValueLists(Vector<SVGTextLayoutAttributes*>&);

+ void reorderValueLists();

void layoutChildBoxes(InlineFlowBox*, LayoutRect* = nullptr);

void layoutRootBox(const LayoutRect&);