Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.h

Issue 1931303002: Simplify SVG layout attribute reordering (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove userData argument/closure. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Oliver Hunt <ojh16@student.canterbury.ac.nz> 2 * Copyright (C) 2006 Oliver Hunt <ojh16@student.canterbury.ac.nz>
3 * Copyright (C) 2006 Apple Computer Inc. 3 * Copyright (C) 2006 Apple Computer Inc.
4 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 4 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
5 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 5 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
11 * 11 *
12 * This library is distributed in the hope that it will be useful, 12 * This library is distributed in the hope that it will be useful,
13 * but WITHOUT ANY WARRANTY; without even the implied warranty of 13 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15 * Library General Public License for more details. 15 * Library General Public License for more details.
16 * 16 *
17 * You should have received a copy of the GNU Library General Public License 17 * You should have received a copy of the GNU Library General Public License
18 * along with this library; see the file COPYING.LIB. If not, write to 18 * along with this library; see the file COPYING.LIB. If not, write to
19 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 19 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
20 * Boston, MA 02110-1301, USA. 20 * Boston, MA 02110-1301, USA.
21 */ 21 */
22 22
23 #ifndef SVGRootInlineBox_h 23 #ifndef SVGRootInlineBox_h
24 #define SVGRootInlineBox_h 24 #define SVGRootInlineBox_h
25 25
26 #include "core/layout/api/LineLayoutBlockFlow.h" 26 #include "core/layout/api/LineLayoutBlockFlow.h"
27 #include "core/layout/line/RootInlineBox.h" 27 #include "core/layout/line/RootInlineBox.h"
28 #include "core/layout/svg/SVGTextLayoutEngine.h"
29 28
30 namespace blink { 29 namespace blink {
31 30
32 class SVGRootInlineBox final : public RootInlineBox { 31 class SVGRootInlineBox final : public RootInlineBox {
33 public: 32 public:
34 SVGRootInlineBox(LineLayoutItem block) 33 SVGRootInlineBox(LineLayoutItem block)
35 : RootInlineBox(block) 34 : RootInlineBox(block)
36 , m_logicalHeight(0) 35 , m_logicalHeight(0)
37 { 36 {
38 } 37 }
39 38
40 bool isSVGRootInlineBox() const override { return true; } 39 bool isSVGRootInlineBox() const override { return true; }
41 40
42 LayoutUnit virtualLogicalHeight() const override { return m_logicalHeight; } 41 LayoutUnit virtualLogicalHeight() const override { return m_logicalHeight; }
43 void setLogicalHeight(LayoutUnit height) { m_logicalHeight = height; } 42 void setLogicalHeight(LayoutUnit height) { m_logicalHeight = height; }
44 43
45 void paint(const PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutU nit lineBottom) const override; 44 void paint(const PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutU nit lineBottom) const override;
46 45
47 void markDirty() override; 46 void markDirty() override;
48 47
49 void computePerCharacterLayoutInformation(); 48 void computePerCharacterLayoutInformation();
50 49
51 InlineBox* closestLeafChildForPosition(const LayoutPoint&); 50 InlineBox* closestLeafChildForPosition(const LayoutPoint&);
52 51
53 bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom ) final; 52 bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom ) final;
54 53
55 private: 54 private:
56 void reorderValueLists(Vector<SVGTextLayoutAttributes*>&); 55 void reorderValueLists();
57 void layoutChildBoxes(InlineFlowBox*, LayoutRect* = nullptr); 56 void layoutChildBoxes(InlineFlowBox*, LayoutRect* = nullptr);
58 void layoutRootBox(const LayoutRect&); 57 void layoutRootBox(const LayoutRect&);
59 58
60 private: 59 private:
61 LayoutUnit m_logicalHeight; 60 LayoutUnit m_logicalHeight;
62 }; 61 };
63 62
64 DEFINE_INLINE_BOX_TYPE_CASTS(SVGRootInlineBox); 63 DEFINE_INLINE_BOX_TYPE_CASTS(SVGRootInlineBox);
65 64
66 } // namespace blink 65 } // namespace blink
67 66
68 #endif // SVGRootInlineBox_h 67 #endif // SVGRootInlineBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698