Let SkPictureBuilder be DisplayItemClient

Let SkPictureBuilder be DisplayItemClient

Some objects implement DisplayItemClient just because they are painted
on SkPictureBuilder. Let SkPictureBuilder be DisplayItemClient can
reduce number of DisplayItemClient implementations. We don't need to
bother their implementation of visualRect() and future client-side
caching status methods.

Committed: https://crrev.com/6684994e2c9f6506f2e3f23a626d4006d268ea0d
Cr-Commit-Position: refs/heads/master@{#390572}

[Xianzhu, 2016-04-28 23:18:33]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2016-04-28 23:18:34]

Will rebase https://codereview.chromium.org/1508223005/ onto this CL.

[chrishtr, 2016-04-29 00:13:26]

Description was changed from

==========
Let SkPictureBuilder be DisplayItemClient

Some objects implements DisplayItemClient just because they are painted
on SkPictureBuilder. Let SkPictureBuilder be DisplayItemClient can
reduce number of DisplayItemClient implementations. We don't need to
bother their implementation of visualRect() and future client-side
caching status methods.
==========

to

==========
Let SkPictureBuilder be DisplayItemClient

Some objects implement DisplayItemClient just because they are painted
on SkPictureBuilder. Let SkPictureBuilder be DisplayItemClient can
reduce number of DisplayItemClient implementations. We don't need to
bother their implementation of visualRect() and future client-side
caching status methods.
==========

[chrishtr, 2016-04-29 00:17:00]

https://codereview.chromium.org/1931133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h
(right):

https://codereview.chromium.org/1931133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h:43:
LayoutRect visualRect() const final { return LayoutRect(); }
ASSERT_NOT_REACHED

[chrishtr, 2016-04-29 00:17:04]

lgtm

[Xianzhu, 2016-04-29 00:39:40]

https://codereview.chromium.org/1931133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h
(right):

https://codereview.chromium.org/1931133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h:43:
LayoutRect visualRect() const final { return LayoutRect(); }
On 2016/04/29 00:17:00, chrishtr wrote:
> ASSERT_NOT_REACHED

For now this is still reached during endRecording() ->
PaintController::commitNewDisplayItems(), though we don't actually use the rect.

[Xianzhu, 2016-04-29 00:40:19]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-04-29 00:40:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931133002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931133002/20001

[commit-bot: I haz the power, 2016-04-29 01:58:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:23:46]

Patchset 2 (id:??) landed as
https://crrev.com/6684994e2c9f6506f2e3f23a626d4006d268ea0d
Cr-Commit-Position: refs/heads/master@{#390572}

[commit-bot: I haz the power, 2016-04-30 17:59:03]

Description was changed from

==========
Let SkPictureBuilder be DisplayItemClient

Some objects implement DisplayItemClient just because they are painted
on SkPictureBuilder. Let SkPictureBuilder be DisplayItemClient can
reduce number of DisplayItemClient implementations. We don't need to
bother their implementation of visualRect() and future client-side
caching status methods.
==========

to

==========
Let SkPictureBuilder be DisplayItemClient

Some objects implement DisplayItemClient just because they are painted
on SkPictureBuilder. Let SkPictureBuilder be DisplayItemClient can
reduce number of DisplayItemClient implementations. We don't need to
bother their implementation of visualRect() and future client-side
caching status methods.

Committed: https://crrev.com/6684994e2c9f6506f2e3f23a626d4006d268ea0d
Cr-Commit-Position: refs/heads/master@{#390572}
==========