Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1525)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h

Issue 1931133002: Let SkPictureBuilder be DisplayItemClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h b/third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h
index 63e7b5fc65d876b378bdf6de613794be00102910..f2652e7a3918a8aec0b90f2318418287631aa218 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.h
@@ -7,6 +7,7 @@
#include "platform/PlatformExport.h"
#include "platform/geometry/FloatRect.h"
+#include "platform/graphics/paint/DisplayItemClient.h"
#include "wtf/Noncopyable.h"
#include "wtf/OwnPtr.h"
#include "wtf/PassRefPtr.h"
@@ -21,7 +22,7 @@ class PaintController;
// When slimming paint ships we can remove this SkPicture abstraction and
// rely on PaintController here.
-class PLATFORM_EXPORT SkPictureBuilder final {
+class PLATFORM_EXPORT SkPictureBuilder final : public DisplayItemClient {
WTF_MAKE_NONCOPYABLE(SkPictureBuilder);
public:
// Constructs a new builder with the given bounds for the resulting recorded picture. If
@@ -37,6 +38,10 @@ public:
// construction.
PassRefPtr<SkPicture> endRecording();
+ // DisplayItemClient methods
+ String debugName() const final { return "SkPictureBuilder"; }
+ LayoutRect visualRect() const final { return LayoutRect(); }
chrishtr 2016/04/29 00:17:00 ASSERT_NOT_REACHED
Xianzhu 2016/04/29 00:39:40 For now this is still reached during endRecording(
+
private:
OwnPtr<PaintController> m_paintController;
OwnPtr<GraphicsContext> m_context;
« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebFont.cpp ('k') | third_party/WebKit/Source/web/PageWidgetDelegate.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698