components/autofill/core/browser/contact_info.cc - Issue 1931123002: [Autofill] Make PersonalDataManager::OverwriteWith case sensitive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/contact_info.cc

Issue 1931123002: [Autofill] Make PersonalDataManager::OverwriteWith case sensitive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_profile.cc ('K') | « components/autofill/core/browser/autofill_profile.cc ('k') | components/autofill/core/browser/contact_info_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/contact_info.cc

diff --git a/components/autofill/core/browser/contact_info.cc b/components/autofill/core/browser/contact_info.cc

index 8db9fc5938208e8f6051049795ebfc1f51adb459..dce870ac27b4944643f06deb7d9308bfebcefd53 100644

--- a/components/autofill/core/browser/contact_info.cc

+++ b/components/autofill/core/browser/contact_info.cc

@@ -39,9 +39,8 @@ NameInfo& NameInfo::operator=(const NameInfo& info) {

bool NameInfo::ParsedNamesAreEqual(const NameInfo& info) const {

Mathieu 2016/04/29 12:23:03 update comment in .h

sebsg 2016/04/29 15:04:49 Done.

l10n::CaseInsensitiveCompare compare;

Mathieu 2016/04/29 12:23:03 no need for compare

sebsg 2016/04/29 15:04:49 Done.

- return compare.StringsEqual(given_, info.given_) &&

- compare.StringsEqual(middle_, info.middle_) &&

- compare.StringsEqual(family_, info.family_);

+ return given_ == info.given_ && middle_ == info.middle_ &&

+ family_ == info.family_;

}

void NameInfo::GetSupportedTypes(ServerFieldTypeSet* supported_types) const {