components/autofill/core/browser/autofill_profile.cc - Issue 1931123002: [Autofill] Make PersonalDataManager::OverwriteWith case sensitive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_profile.cc

Issue 1931123002: [Autofill] Make PersonalDataManager::OverwriteWith case sensitive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_profile.h ('K') | « components/autofill/core/browser/autofill_profile.h ('k') | components/autofill/core/browser/contact_info.cc » ('j') | components/autofill/core/browser/contact_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_profile.cc

diff --git a/components/autofill/core/browser/autofill_profile.cc b/components/autofill/core/browser/autofill_profile.cc

index 1234c0c7257b331d3c06c7e4f5abfeb183600280..b65c10bad9c108d71582c05d58e251401576546b 100644

--- a/components/autofill/core/browser/autofill_profile.cc

+++ b/components/autofill/core/browser/autofill_profile.cc

@@ -565,7 +565,7 @@ bool AutofillProfile::OverwriteWith(const AutofillProfile& profile,

}

base::string16 new_value = profile.GetRawInfo(*iter);

Mathieu 2016/04/29 12:18:43 Add a comment: // Overwrite the data in |this| pro

sebsg 2016/04/29 15:04:48 Done.

- if (!compare.StringsEqual(GetRawInfo(*iter), new_value)) {

+ if (GetRawInfo(*iter) != new_value) {

SetRawInfo(*iter, new_value);

did_overwrite = true;

}