[Autofill] Make PersonalDataManager::OverwriteWith case sensitive.

components/autofill/core/browser/contact_info.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/contact_info.h"
 
 #include <stddef.h>
 #include <ostream>
 #include <string>
 
@@ skipping 19 matching lines @@
   if (this == &info)
     return *this;
 
   given_ = info.given_;
   middle_ = info.middle_;
   family_ = info.family_;
   full_ = info.full_;
   return *this;
 }
 
 bool NameInfo::ParsedNamesAreEqual(const NameInfo& info) const {

[Mathieu, 2016/04/29 12:23:03]

update comment in .h

[sebsg, 2016/04/29 15:04:49]

Done.

   l10n::CaseInsensitiveCompare compare;

[Mathieu, 2016/04/29 12:23:03]

no need for compare

[sebsg, 2016/04/29 15:04:49]

Done.

-  return compare.StringsEqual(given_, info.given_) &&
-         compare.StringsEqual(middle_, info.middle_) &&
-         compare.StringsEqual(family_, info.family_);
+  return given_ == info.given_ && middle_ == info.middle_ &&
+         family_ == info.family_;
 }
 
 void NameInfo::GetSupportedTypes(ServerFieldTypeSet* supported_types) const {
   supported_types->insert(NAME_FIRST);
   supported_types->insert(NAME_MIDDLE);
   supported_types->insert(NAME_LAST);
   supported_types->insert(NAME_MIDDLE_INITIAL);
   supported_types->insert(NAME_FULL);
 }
 
@@ skipping 169 matching lines @@
   return base::string16();
 }
 
 void CompanyInfo::SetRawInfo(ServerFieldType type,
                              const base::string16& value) {
   DCHECK_EQ(COMPANY_NAME, type);
   company_name_ = value;
 }
 
 }  // namespace autofill