[Autofill] Make PersonalDataManager::OverwriteWith case sensitive.

components/autofill/core/browser/autofill_profile.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_profile.h"
 
 #include <algorithm>
 #include <functional>
 #include <map>
 #include <memory>
@@ skipping 507 matching lines @@
 bool AutofillProfile::OverwriteWith(const AutofillProfile& profile,
                                     const std::string& app_locale) {
   // Verified profiles should never be overwritten with unverified data.
   DCHECK(!IsVerified() || profile.IsVerified());
   set_origin(profile.origin());
   set_language_code(profile.language_code());
   set_use_count(profile.use_count() + use_count());
   if (profile.use_date() > use_date())
     set_use_date(profile.use_date());
 
   ServerFieldTypeSet field_types;

[Mathieu, 2016/04/29 12:18:43]

add a comment about |field_types|. Perhaps rename "types_to_override"?

// |field_types| is initially populated with all types that have non-empty data
in the incoming |profile|. After adjustment, all data from |profile|
corresponding to types in |field_types| is overwritten in |this| profile.

[sebsg, 2016/04/29 15:04:49]

Done.

   profile.GetNonEmptyTypes(app_locale, &field_types);
 
   // Only transfer "full" types (e.g. full name) and not fragments (e.g.
   // first name, last name).
   CollapseCompoundFieldTypes(&field_types);
 
   // Remove ADDRESS_HOME_STREET_ADDRESS to ensure a merge of the address line by
   // line. See comment below.
   field_types.erase(ADDRESS_HOME_STREET_ADDRESS);
 
@@ skipping 13 matching lines @@
     field_types.erase(ADDRESS_HOME_LINE2);
   }
 
   bool did_overwrite = false;
 
   for (ServerFieldTypeSet::const_iterator iter = field_types.begin();
        iter != field_types.end(); ++iter) {
     FieldTypeGroup group = AutofillType(*iter).group();
 
     // Special case names.
     if (group == NAME) {

[Mathieu, 2016/04/29 12:18:43]

nit: inline AutofillType(*iter).group() here

[sebsg, 2016/04/29 15:04:49]

Done.

       did_overwrite = OverwriteName(profile.name_, app_locale) || did_overwrite;

[Mathieu, 2016/04/29 12:18:43]

seems like we are going to run OverwriteName for all types in group NAME, right?
possible future optimization?

[Mathieu, 2016/04/29 12:18:43]

optional nit: did_overwrite |= OverwriteName(...) is clearer at least to me.

[sebsg, 2016/04/29 15:04:49]

Done.

[sebsg, 2016/04/29 15:04:49]

CollapseCompoundFieldTypes makes sure we only overwrite full types so it should
only run once.

       continue;
     }
 
     base::string16 new_value = profile.GetRawInfo(*iter);

[Mathieu, 2016/04/29 12:18:43]

Add a comment: // Overwrite the data in |this| profile for the field type. Set
|did_overwrite| if previous data was different.

[sebsg, 2016/04/29 15:04:48]

Done.

-    if (!compare.StringsEqual(GetRawInfo(*iter), new_value)) {
+    if (GetRawInfo(*iter) != new_value) {
       SetRawInfo(*iter, new_value);
       did_overwrite = true;
     }
   }
 
   return did_overwrite;
 }
 
 bool AutofillProfile::SaveAdditionalInfo(const AutofillProfile& profile,
                                          const std::string& app_locale) {
@@ skipping 471 matching lines @@
             << " " << UTF16ToUTF8(profile.GetRawInfo(ADDRESS_HOME_CITY)) << " "
             << UTF16ToUTF8(profile.GetRawInfo(ADDRESS_HOME_STATE)) << " "
             << UTF16ToUTF8(profile.GetRawInfo(ADDRESS_HOME_ZIP)) << " "
             << UTF16ToUTF8(profile.GetRawInfo(ADDRESS_HOME_SORTING_CODE)) << " "
             << UTF16ToUTF8(profile.GetRawInfo(ADDRESS_HOME_COUNTRY)) << " "
             << profile.language_code() << " "
             << UTF16ToUTF8(profile.GetRawInfo(PHONE_HOME_WHOLE_NUMBER));
 }
 
 }  // namespace autofill