Remove requestAutocomplete

Remove requestAutocomplete

Also fix some libaddressinput dependencies/includes which incorrectly used ENABLE_AUTOFILL_DIALOG (since libaddressinput is used for chrome://settings/autofill regardless of the use of the dialog).

Also move some color constants closer to where they're used for the card unmask dialog.

BUG=337587, 608824
TBR=palmer@chromium.org

Committed: https://crrev.com/e62c2a4c85f206833cb058932cfe62b3c347c685
Cr-Commit-Position: refs/heads/master@{#391821}

[Evan Stade, 2016-04-29 16:06:14]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 16:06:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931043002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931043002/20001

[commit-bot: I haz the power, 2016-04-29 16:18:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 16:18:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Evan Stade, 2016-04-29 19:30:11]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 19:30:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931043002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931043002/40001

[commit-bot: I haz the power, 2016-04-29 19:47:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 19:47:45]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Evan Stade, 2016-05-01 15:11:42]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-01 21:49:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931043002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931043002/50001

[commit-bot: I haz the power, 2016-05-01 23:25:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-01 23:25:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2016-05-03 18:00:25]

Description was changed from

==========
WIP - Remove requestAutocomplete

BUG=
==========

to

==========
Remove requestAutocomplete

BUG=337587, 608824
==========

[Evan Stade, 2016-05-03 18:00:25]

estade@chromium.org changed reviewers:
+ brettw@chromium.org, groby@chromium.org

[Evan Stade, 2016-05-03 18:00:44]

+groby for cocoa/
+brettw for the rest

[Evan Stade, 2016-05-03 18:00:53]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 18:01:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931043002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931043002/70001

[brettw, 2016-05-03 19:17:21]

You also changed some libaddressinput dependencies around (I presume because
they're no longer being brought in by rAC) and fixed some infobar coloring. The
CL description should cover both of these changes.

LGTM with that.

[commit-bot: I haz the power, 2016-05-03 21:31:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 21:31:08]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-05-03 22:33:03]

Description was changed from

==========
Remove requestAutocomplete

BUG=337587, 608824
==========

to

==========
Remove requestAutocomplete

Also fix some libaddressinput dependencies/includes which incorrectly depended
on ENABLE_AUTOFILL_DIALOG (since libaddressinput is used for
chrome://settings/autofill regardless of the use of the dialog).

BUG=337587, 608824
==========

[Evan Stade, 2016-05-03 22:33:19]

Description was changed from

==========
Remove requestAutocomplete

Also fix some libaddressinput dependencies/includes which incorrectly depended
on ENABLE_AUTOFILL_DIALOG (since libaddressinput is used for
chrome://settings/autofill regardless of the use of the dialog).

BUG=337587, 608824
==========

to

==========
Remove requestAutocomplete

Also fix some libaddressinput dependencies/includes which incorrectly used
ENABLE_AUTOFILL_DIALOG (since libaddressinput is used for
chrome://settings/autofill regardless of the use of the dialog).

BUG=337587, 608824
==========

[Evan Stade, 2016-05-04 00:13:13]

On 2016/05/03 19:17:21, brettw wrote:
> You also changed some libaddressinput dependencies around (I presume because
> they're no longer being brought in by rAC) and fixed some infobar coloring.
The
> CL description should cover both of these changes.
> 
> LGTM with that.

I updated the description for the libaddressinput stuff, but I'm not sure what
you mean by infobar coloring. Are you talking about kWarningColor ->
gfx::kGoogleRed500? Because that's functionally equivalent.

[brettw, 2016-05-04 00:23:31]

On 2016/05/04 00:13:13, Evan Stade wrote:
> I updated the description for the libaddressinput stuff, but I'm not sure what
> you mean by infobar coloring. Are you talking about kWarningColor ->
> gfx::kGoogleRed500? Because that's functionally equivalent.

Yeah, this and some related stuff. It seems like the CL description should
mention infobar color cleanup or something, if only to help find the blame in
case somebody notices the colors are wrong.

[Evan Stade, 2016-05-04 00:30:05]

On 2016/05/04 00:23:31, brettw wrote:
> On 2016/05/04 00:13:13, Evan Stade wrote:
> > I updated the description for the libaddressinput stuff, but I'm not sure
what
> > you mean by infobar coloring. Are you talking about kWarningColor ->
> > gfx::kGoogleRed500? Because that's functionally equivalent.
> 
> Yeah, this and some related stuff. It seems like the CL description should
> mention infobar color cleanup or something, if only to help find the blame in
> case somebody notices the colors are wrong.

I'm still missing what infobar this CL affects.

[groby-ooo-7-16, 2016-05-04 00:30:45]

On 2016/05/04 00:23:31, brettw wrote:
> On 2016/05/04 00:13:13, Evan Stade wrote:
> > I updated the description for the libaddressinput stuff, but I'm not sure
what
> > you mean by infobar coloring. Are you talking about kWarningColor ->
> > gfx::kGoogleRed500? Because that's functionally equivalent.
> 
> Yeah, this and some related stuff. It seems like the CL description should
> mention infobar color cleanup or something, if only to help find the blame in
> case somebody notices the colors are wrong.

c/b/ui/cocoa RS LGTM (since it's just deletions & 1 minor edit. I'll trust the
trybots to find gyp/gn issues)

[brettw, 2016-05-04 03:11:10]

I misremembered, I was thinking about the color changes in
card_unmask_prompt_views (slightly more involved than just the red constant).

[Evan Stade, 2016-05-04 03:47:31]

On 2016/05/04 03:11:10, brettw wrote:
> I misremembered, I was thinking about the color changes in
> card_unmask_prompt_views (slightly more involved than just the red constant).

that's also just moving some constants around, no effective change. But it is
weird and unintentional that it's now using both Red700 and kWarningColor.

[Evan Stade, 2016-05-04 03:51:53]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 03:52:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931043002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931043002/90001

[commit-bot: I haz the power, 2016-05-04 06:43:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 06:43:10]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-05-04 15:10:22]

Description was changed from

==========
Remove requestAutocomplete

Also fix some libaddressinput dependencies/includes which incorrectly used
ENABLE_AUTOFILL_DIALOG (since libaddressinput is used for
chrome://settings/autofill regardless of the use of the dialog).

BUG=337587, 608824
==========

to

==========
Remove requestAutocomplete

Also fix some libaddressinput dependencies/includes which incorrectly used
ENABLE_AUTOFILL_DIALOG (since libaddressinput is used for
chrome://settings/autofill regardless of the use of the dialog).

Also move some color constants closer to where they're used for the card unmask
dialog.

BUG=337587, 608824
==========

[Evan Stade, 2016-05-04 15:10:37]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-05-04 15:10:38]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1931043002/#ps90001
(title: "fix color reference")

[commit-bot: I haz the power, 2016-05-04 15:10:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931043002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931043002/90001

[commit-bot: I haz the power, 2016-05-04 15:17:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 15:17:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2016-05-05 00:11:05]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-05-05 00:11:06]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1931043002/#ps110001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-05 00:11:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931043002/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931043002/110001

[commit-bot: I haz the power, 2016-05-05 00:23:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 00:23:22]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2016-05-05 14:51:29]

Description was changed from

==========
Remove requestAutocomplete

Also fix some libaddressinput dependencies/includes which incorrectly used
ENABLE_AUTOFILL_DIALOG (since libaddressinput is used for
chrome://settings/autofill regardless of the use of the dialog).

Also move some color constants closer to where they're used for the card unmask
dialog.

BUG=337587, 608824
==========

to

==========
Remove requestAutocomplete

Also fix some libaddressinput dependencies/includes which incorrectly used
ENABLE_AUTOFILL_DIALOG (since libaddressinput is used for
chrome://settings/autofill regardless of the use of the dialog).

Also move some color constants closer to where they're used for the card unmask
dialog.

BUG=337587, 608824
TBR=palmer@chromium.org
==========

[Evan Stade, 2016-05-05 14:51:30]

estade@chromium.org changed reviewers:
+ palmer@chromium.org

[Evan Stade, 2016-05-05 14:51:48]

tbr palmer for deletion from autofill_messages.h

[Evan Stade, 2016-05-05 14:51:58]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-05-05 14:52:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931043002/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931043002/110001

[commit-bot: I haz the power, 2016-05-05 16:27:40]

Description was changed from

==========
Remove requestAutocomplete

Also fix some libaddressinput dependencies/includes which incorrectly used
ENABLE_AUTOFILL_DIALOG (since libaddressinput is used for
chrome://settings/autofill regardless of the use of the dialog).

Also move some color constants closer to where they're used for the card unmask
dialog.

BUG=337587, 608824
TBR=palmer@chromium.org
==========

to

==========
Remove requestAutocomplete

Also fix some libaddressinput dependencies/includes which incorrectly used
ENABLE_AUTOFILL_DIALOG (since libaddressinput is used for
chrome://settings/autofill regardless of the use of the dialog).

Also move some color constants closer to where they're used for the card unmask
dialog.

BUG=337587, 608824
TBR=palmer@chromium.org
==========

[commit-bot: I haz the power, 2016-05-05 16:27:42]

Committed patchset #7 (id:110001)

[commit-bot: I haz the power, 2016-05-05 16:29:01]

Description was changed from

==========
Remove requestAutocomplete

Also fix some libaddressinput dependencies/includes which incorrectly used
ENABLE_AUTOFILL_DIALOG (since libaddressinput is used for
chrome://settings/autofill regardless of the use of the dialog).

Also move some color constants closer to where they're used for the card unmask
dialog.

BUG=337587, 608824
TBR=palmer@chromium.org
==========

to

==========
Remove requestAutocomplete

Also fix some libaddressinput dependencies/includes which incorrectly used
ENABLE_AUTOFILL_DIALOG (since libaddressinput is used for
chrome://settings/autofill regardless of the use of the dialog).

Also move some color constants closer to where they're used for the card unmask
dialog.

BUG=337587, 608824
TBR=palmer@chromium.org

Committed: https://crrev.com/e62c2a4c85f206833cb058932cfe62b3c347c685
Cr-Commit-Position: refs/heads/master@{#391821}
==========

[commit-bot: I haz the power, 2016-05-05 16:29:03]

Patchset 7 (id:??) landed as
https://crrev.com/e62c2a4c85f206833cb058932cfe62b3c347c685
Cr-Commit-Position: refs/heads/master@{#391821}