Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: chrome/browser/ui/autofill/chrome_autofill_client.cc

Issue 1931043002: Remove requestAutocomplete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/chrome_autofill_client.cc
diff --git a/chrome/browser/ui/autofill/chrome_autofill_client.cc b/chrome/browser/ui/autofill/chrome_autofill_client.cc
index f3e4ad674c4cea16cfab55e1174a963939a195bf..cbe2cc16b8609b239ed236adcd9df13a65933b5b 100644
--- a/chrome/browser/ui/autofill/chrome_autofill_client.cc
+++ b/chrome/browser/ui/autofill/chrome_autofill_client.cc
@@ -20,7 +20,6 @@
#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
#include "chrome/browser/signin/signin_manager_factory.h"
#include "chrome/browser/sync/profile_sync_service_factory.h"
-#include "chrome/browser/ui/autofill/autofill_dialog_controller.h"
#include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
#include "chrome/browser/ui/autofill/create_card_unmask_prompt_view.h"
#include "chrome/browser/ui/autofill/credit_card_scanner_controller.h"
@@ -71,8 +70,7 @@ ChromeAutofillClient::ChromeAutofillClient(content::WebContents* web_contents)
unmask_controller_(
user_prefs::UserPrefs::Get(web_contents->GetBrowserContext()),
Profile::FromBrowserContext(web_contents->GetBrowserContext())
- ->IsOffTheRecord()),
- last_rfh_to_rac_(nullptr) {
+ ->IsOffTheRecord()) {
DCHECK(web_contents);
#if !BUILDFLAG(ANDROID_JAVA_UI)
@@ -97,11 +95,6 @@ ChromeAutofillClient::~ChromeAutofillClient() {
DCHECK(!popup_controller_);
}
-void ChromeAutofillClient::TabActivated() {
- if (dialog_controller_.get())
- dialog_controller_->TabActivated();
-}
-
PersonalDataManager* ChromeAutofillClient::GetPersonalDataManager() {
Profile* profile =
Profile::FromBrowserContext(web_contents()->GetBrowserContext());
@@ -225,25 +218,6 @@ void ChromeAutofillClient::ScanCreditCard(
CreditCardScannerController::ScanCreditCard(web_contents(), callback);
}
-void ChromeAutofillClient::ShowRequestAutocompleteDialog(
- const FormData& form,
- content::RenderFrameHost* render_frame_host,
- const ResultCallback& callback) {
- HideRequestAutocompleteDialog();
- last_rfh_to_rac_ = render_frame_host;
- GURL frame_url = render_frame_host->GetLastCommittedURL();
- dialog_controller_ = AutofillDialogController::Create(web_contents(), form,
- frame_url, callback);
- if (dialog_controller_) {
- dialog_controller_->Show();
- } else {
- callback.Run(AutofillClient::AutocompleteResultErrorDisabled,
- base::string16(),
- NULL);
- NOTIMPLEMENTED();
- }
-}
-
void ChromeAutofillClient::ShowAutofillPopup(
const gfx::RectF& element_bounds,
base::i18n::TextDirection text_direction,
@@ -290,25 +264,6 @@ bool ChromeAutofillClient::IsAutocompleteEnabled() {
return GetPrefs()->GetBoolean(prefs::kAutofillEnabled);
}
-void ChromeAutofillClient::HideRequestAutocompleteDialog() {
- if (dialog_controller_)
- dialog_controller_->Hide();
-}
-
-void ChromeAutofillClient::RenderFrameDeleted(
- content::RenderFrameHost* render_frame_host) {
- if (dialog_controller_ && render_frame_host == last_rfh_to_rac_)
- HideRequestAutocompleteDialog();
-}
-
-void ChromeAutofillClient::DidNavigateAnyFrame(
- content::RenderFrameHost* render_frame_host,
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) {
- if (dialog_controller_ && render_frame_host == last_rfh_to_rac_)
- HideRequestAutocompleteDialog();
-}
-
void ChromeAutofillClient::MainFrameWasResized(bool width_changed) {
#if BUILDFLAG(ANDROID_JAVA_UI)
// Ignore virtual keyboard showing and hiding a strip of suggestions.
« no previous file with comments | « chrome/browser/ui/autofill/chrome_autofill_client.h ('k') | chrome/browser/ui/autofill/country_combobox_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698