Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: components/autofill/core/browser/autofill_client.h

Issue 1931043002: Remove requestAutocomplete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_client.h
diff --git a/components/autofill/core/browser/autofill_client.h b/components/autofill/core/browser/autofill_client.h
index 251196eae4189222e3cb67103c8d6b669f23c4a9..b83d6efb087e4a98f08399a8105c65ae2cd53e83 100644
--- a/components/autofill/core/browser/autofill_client.h
+++ b/components/autofill/core/browser/autofill_client.h
@@ -58,14 +58,6 @@ struct Suggestion;
// for the tab the AutofillManager is attached to).
class AutofillClient {
public:
- // Copy of blink::WebFormElement::AutocompleteResult.
- enum RequestAutocompleteResult {
- AutocompleteResultSuccess,
- AutocompleteResultErrorDisabled,
- AutocompleteResultErrorCancel,
- AutocompleteResultErrorInvalid,
- };
-
enum PaymentsRpcResult {
// Empty result. Used for initializing variables and should generally
// not be returned nor passed as arguments unless explicitly allowed by
@@ -94,10 +86,6 @@ class AutofillClient {
UNMASK_FOR_AUTOFILL,
};
- typedef base::Callback<void(RequestAutocompleteResult,
- const base::string16&,
- const FormStructure*)> ResultCallback;
-
typedef base::Callback<void(const base::string16& /* card number */,
int /* exp month */,
int /* exp year */)> CreditCardScanCallback;
@@ -122,9 +110,6 @@ class AutofillClient {
// Gets the RapporService associated with the client (for metrics).
virtual rappor::RapporService* GetRapporService() = 0;
- // Hides the associated request autocomplete dialog (if it exists).
- virtual void HideRequestAutocompleteDialog() = 0;
-
// Causes the Autofill settings UI to be shown.
virtual void ShowAutofillSettings() = 0;
@@ -160,12 +145,6 @@ class AutofillClient {
// HasCreditCardScanFeature() returns true.
virtual void ScanCreditCard(const CreditCardScanCallback& callback) = 0;
- // Causes the dialog for request autocomplete feature to be shown.
- virtual void ShowRequestAutocompleteDialog(
- const FormData& form,
- content::RenderFrameHost* render_frame_host,
- const ResultCallback& callback) = 0;
-
// Shows an Autofill popup with the given |values|, |labels|, |icons|, and
// |identifiers| for the element at |element_bounds|. |delegate| will be
// notified of popup events.
« no previous file with comments | « components/autofill/content/renderer/autofill_agent.cc ('k') | components/autofill/core/browser/autofill_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698