[compiler] Untangle CompilationInfo allocated with new.

[compiler] Untangle CompilationInfo allocated with new.

This removes the CompilationInfoWithZone class, which was used to
allocate a CompilationInfo on the C-heap. By now the CompilationJob is
the single object being allocated on the C-heap and passed between the
main thread and the compilation thread. Structs requiring destruction
can be embedded within that CompilationJob. This simplifies involved
lifetimes by coupling all lifetimes to one single object.

R=bmeurer@chromium.org

Committed: https://crrev.com/601ee4ebf4ac9f626ccfeeb2d36e155220ad07e0
Cr-Commit-Position: refs/heads/master@{#35936}

[Michael Starzinger, 2016-04-28 09:51:38]

Description was changed from

==========
[compiler] Untangle CompilationInfo allocated with new.

This removes the CompilationInfoWithZone class, which was used to
allocate a CompilationInfo on the C-heap. By now the CompilationJob is
the single object being allocated on the C-heap and passed between the
main thread and the compilation thread. Structs requiring destruction
can be embedded within that CompilationJob. This simplifies involved
lifetimes by coupling all lifetimes to one single object.

R=
==========

to

==========
[compiler] Untangle CompilationInfo allocated with new.

This removes the CompilationInfoWithZone class, which was used to
allocate a CompilationInfo on the C-heap. By now the CompilationJob is
the single object being allocated on the C-heap and passed between the
main thread and the compilation thread. Structs requiring destruction
can be embedded within that CompilationJob. This simplifies involved
lifetimes by coupling all lifetimes to one single object.

R=bmeurer@chromium.org
==========

[Michael Starzinger, 2016-04-28 09:51:39]

mstarzinger@chromium.org changed reviewers:
+ ahaas@chromium.org, bmeurer@chromium.org

[Michael Starzinger, 2016-04-28 09:51:52]

Benedikt: PTAL.
Andreas: FYI.

[Benedikt Meurer, 2016-04-28 10:23:02]

Gekauft! LGTM with comments.

https://codereview.chromium.org/1930773003/diff/40001/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/1930773003/diff/40001/src/compiler.h#newcode142
src/compiler.h:142: class CompilationInfo final BASE_EMBEDDED {
Please don't use the BASE_EMBEDDED macro.

https://codereview.chromium.org/1930773003/diff/40001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/1930773003/diff/40001/src/compiler/pipeline.c...
src/compiler/pipeline.cc:507: : CompilationJob(&info_, "TurboFan"),
Hm, info_ is uninitialized memory at this point. Are we ok with that?
Please leave a comment here.

[Michael Starzinger, 2016-05-02 12:35:06]

Thanks! Comments addressed. Landing.

https://codereview.chromium.org/1930773003/diff/40001/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/1930773003/diff/40001/src/compiler.h#newcode142
src/compiler.h:142: class CompilationInfo final BASE_EMBEDDED {
On 2016/04/28 10:23:02, Benedikt Meurer wrote:
> Please don't use the BASE_EMBEDDED macro.

Done.

https://codereview.chromium.org/1930773003/diff/40001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):

https://codereview.chromium.org/1930773003/diff/40001/src/compiler/pipeline.c...
src/compiler/pipeline.cc:507: : CompilationJob(&info_, "TurboFan"),
On 2016/04/28 10:23:02, Benedikt Meurer wrote:
> Hm, info_ is uninitialized memory at this point. Are we ok with that?
> Please leave a comment here.

Done.

[Michael Starzinger, 2016-05-02 14:40:05]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-05-02 14:40:06]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1930773003/#ps100001
(title: "Fix initialization order.")

[commit-bot: I haz the power, 2016-05-02 14:40:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1930773003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1930773003/100001

[commit-bot: I haz the power, 2016-05-02 14:44:34]

Description was changed from

==========
[compiler] Untangle CompilationInfo allocated with new.

This removes the CompilationInfoWithZone class, which was used to
allocate a CompilationInfo on the C-heap. By now the CompilationJob is
the single object being allocated on the C-heap and passed between the
main thread and the compilation thread. Structs requiring destruction
can be embedded within that CompilationJob. This simplifies involved
lifetimes by coupling all lifetimes to one single object.

R=bmeurer@chromium.org
==========

to

==========
[compiler] Untangle CompilationInfo allocated with new.

This removes the CompilationInfoWithZone class, which was used to
allocate a CompilationInfo on the C-heap. By now the CompilationJob is
the single object being allocated on the C-heap and passed between the
main thread and the compilation thread. Structs requiring destruction
can be embedded within that CompilationJob. This simplifies involved
lifetimes by coupling all lifetimes to one single object.

R=bmeurer@chromium.org
==========

[commit-bot: I haz the power, 2016-05-02 14:44:35]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-02 14:46:44]

Description was changed from

==========
[compiler] Untangle CompilationInfo allocated with new.

This removes the CompilationInfoWithZone class, which was used to
allocate a CompilationInfo on the C-heap. By now the CompilationJob is
the single object being allocated on the C-heap and passed between the
main thread and the compilation thread. Structs requiring destruction
can be embedded within that CompilationJob. This simplifies involved
lifetimes by coupling all lifetimes to one single object.

R=bmeurer@chromium.org
==========

to

==========
[compiler] Untangle CompilationInfo allocated with new.

This removes the CompilationInfoWithZone class, which was used to
allocate a CompilationInfo on the C-heap. By now the CompilationJob is
the single object being allocated on the C-heap and passed between the
main thread and the compilation thread. Structs requiring destruction
can be embedded within that CompilationJob. This simplifies involved
lifetimes by coupling all lifetimes to one single object.

R=bmeurer@chromium.org

Committed: https://crrev.com/601ee4ebf4ac9f626ccfeeb2d36e155220ad07e0
Cr-Commit-Position: refs/heads/master@{#35936}
==========

[commit-bot: I haz the power, 2016-05-02 14:46:44]

Patchset 6 (id:??) landed as
https://crrev.com/601ee4ebf4ac9f626ccfeeb2d36e155220ad07e0
Cr-Commit-Position: refs/heads/master@{#35936}