src/compiler/pipeline.h - Issue 1930773003: [compiler] Untangle CompilationInfo allocated with new.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/pipeline.h

Issue 1930773003: [compiler] Untangle CompilationInfo allocated with new. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-simplify-30

Patch Set: Fix initialization order. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/pipeline.h

diff --git a/src/compiler/pipeline.h b/src/compiler/pipeline.h

index da4a2150296c49c318951aac25ade7dcaeeeec3d..4721e51587adc6fb6d6a755f5845b13ced049bd3 100644

--- a/src/compiler/pipeline.h

+++ b/src/compiler/pipeline.h

@@ -72,8 +72,8 @@ class Pipeline {

Graph* graph,

Schedule* schedule = nullptr);

- // Returns a new compilation job for the given compilation info.

- static CompilationJob* NewCompilationJob(CompilationInfo* info);

+ // Returns a new compilation job for the given function.

+ static CompilationJob* NewCompilationJob(Handle<JSFunction> function);

// Returns a new compilation job for the WebAssembly compilation info.

static CompilationJob* NewWasmCompilationJob(

« no previous file with comments | « src/compiler.cc ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »