Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1938893002: [build] Fix Makefile based build. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Fix Makefile based build. This fixes the Python include path after the GYP files have been relocated into another directory. R=machenbach@chromium.org Committed: https://crrev.com/ee69b4ff319430fc2799a18fcbd7b1f2f0fb4888 Cr-Commit-Position: refs/heads/master@{#35928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (2 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-02 09:01:32 UTC) #1
Michael Achenbach
lgtm
4 years, 7 months ago (2016-05-02 09:21:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1938893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1938893002/1
4 years, 7 months ago (2016-05-02 09:29:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 09:41:54 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ee69b4ff319430fc2799a18fcbd7b1f2f0fb4888 Cr-Commit-Position: refs/heads/master@{#35928}
4 years, 7 months ago (2016-05-02 09:42:16 UTC) #7
caitp (gmail)
icu.gyp still includes build/shim_headers.gypi on 2 lines, which causes Makefile builds to fail. Can you ...
4 years, 7 months ago (2016-05-02 12:45:36 UTC) #8
Michael Achenbach
On 2016/05/02 12:45:36, caitp wrote: > icu.gyp still includes build/shim_headers.gypi on 2 lines, which causes ...
4 years, 7 months ago (2016-05-02 12:49:17 UTC) #9
Michael Achenbach
On 2016/05/02 12:49:17, Michael Achenbach wrote: > On 2016/05/02 12:45:36, caitp wrote: > > icu.gyp ...
4 years, 7 months ago (2016-05-02 12:50:15 UTC) #10
caitp (gmail)
4 years, 7 months ago (2016-05-02 12:52:49 UTC) #11
Message was sent while issue was closed.
On 2016/05/02 12:49:17, Michael Achenbach wrote:
> On 2016/05/02 12:45:36, caitp wrote:
> > icu.gyp still includes build/shim_headers.gypi on 2 lines, which causes
> Makefile
> > builds to fail.
> > 
> > Can you submit a followup to fix that?
> 
> But that should work after a gclient sync. It pulls "build" from chromium
which
> includes that file.

ah, I see. `gclient sync` was failing for some unrelated reason

Powered by Google App Engine
This is Rietveld 408576698