Always set symbol visibility when compiling with GCC / Clang.

Always set symbol visibility when compiling with GCC / Clang.

By default, GN includes //build/config/gcc:symbol_visibility_hidden
into every target. Some targets remove this config. At least some of
the compiler options require the visibility to be set explicitly,
and they issue a compiler error otherwise.

This change is a follow up to src/ counterpart:
https://codereview.chromium.org/1930773002/

BUG=607370
R=glider@chromium.org

Committed: b4232ffa4e00eb04cb76deffe9a0c19e9b2e0e65

[krasin, 2016-04-28 16:27:19]

krasin@google.com changed reviewers:
+ glider@chromium.org

[krasin, 2016-04-30 03:09:04]

Hi Sasha,

this is just a friendly bump of the review request in your inbox. I hope you
spot it on Monday.

Have a good weekend,
krasin

[Alexander Potapenko, 2016-05-02 11:51:34]

LGTM

[krasin, 2016-05-02 16:15:09]

Description was changed from

==========
Always set symbol visibility when compiling with GCC / Clang.

By default, GN includes //build/config/gcc:symbol_visibility_hidden
into every target. Some targets remove this config. At least some of
the compiler options require the visibility to be set explicitly,
and they issue a compiler error otherwise.

This change is a follow up to src/ counterpart:
https://codereview.chromium.org/1930773002/

BUG=607370
==========

to

==========
Always set symbol visibility when compiling with GCC / Clang.

By default, GN includes //build/config/gcc:symbol_visibility_hidden
into every target. Some targets remove this config. At least some of
the compiler options require the visibility to be set explicitly,
and they issue a compiler error otherwise.

This change is a follow up to src/ counterpart:
https://codereview.chromium.org/1930773002/

BUG=607370
R=glider@chromium.org

Committed: b4232ffa4e00eb04cb76deffe9a0c19e9b2e0e65
==========

[krasin, 2016-05-02 16:15:10]

Committed patchset #2 (id:20001) manually as
b4232ffa4e00eb04cb76deffe9a0c19e9b2e0e65 (presubmit successful).

[krasin, 2016-05-02 16:15:41]

Do we need to roll deps to get this change into src/?

[Alexander Potapenko, 2016-05-02 16:21:15]

On 2016/05/02 16:15:41, krasin wrote:
> Do we need to roll deps to get this change into src/?

I think the answer is yes, at least third_party/libc++{,abi} are listed in
buildtools/DEPS in Chromium tree.