Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: third_party/libc++/BUILD.gn

Issue 1930753004: Always set symbol visibility when compiling with GCC / Clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/buildtools.git@master
Patch Set: sync Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/libc++abi/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Used by libc++ and libc++abi. 5 # Used by libc++ and libc++abi.
6 config("config") { 6 config("config") {
7 defines = [ "LIBCXX_BUILDING_LIBCXXABI" ] 7 defines = [ "LIBCXX_BUILDING_LIBCXXABI" ]
8 cflags = [ 8 cflags = [
9 "-fPIC", 9 "-fPIC",
10 "-fstrict-aliasing", 10 "-fstrict-aliasing",
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 configs -= [ 51 configs -= [
52 "//build/config/compiler:chromium_code", 52 "//build/config/compiler:chromium_code",
53 "//build/config/compiler:no_rtti", 53 "//build/config/compiler:no_rtti",
54 "//build/config/gcc:no_exceptions", 54 "//build/config/gcc:no_exceptions",
55 "//build/config/gcc:symbol_visibility_hidden", 55 "//build/config/gcc:symbol_visibility_hidden",
56 ] 56 ]
57 configs += [ 57 configs += [
58 ":config", 58 ":config",
59 "//build/config/compiler:no_chromium_code", 59 "//build/config/compiler:no_chromium_code",
60 "//build/config/compiler:rtti", 60 "//build/config/compiler:rtti",
61 "//build/config/gcc:symbol_visibility_default",
61 "//build/config/sanitizers:sanitizer_options_link_helper", 62 "//build/config/sanitizers:sanitizer_options_link_helper",
62 ] 63 ]
63 64
64 ldflags = [ "-nodefaultlibs" ] 65 ldflags = [ "-nodefaultlibs" ]
65 66
66 # TODO(GYP): Remove "-pthread" from ldflags. 67 # TODO(GYP): Remove "-pthread" from ldflags.
67 # -nodefaultlibs turns -pthread into a no-op, causing an unused argument 68 # -nodefaultlibs turns -pthread into a no-op, causing an unused argument
68 # warning. Explicitly link with -lpthread instead. 69 # warning. Explicitly link with -lpthread instead.
69 70
70 libs = [ 71 libs = [
(...skipping 27 matching lines...) Expand all
98 "-stdlib=libc++", 99 "-stdlib=libc++",
99 100
100 # Normally the generator takes care of RPATH. Our case is special because 101 # Normally the generator takes care of RPATH. Our case is special because
101 # the generator is unaware of the libc++.so dependency. Note that setting 102 # the generator is unaware of the libc++.so dependency. Note that setting
102 # RPATH here is a potential security issue. See the following for another 103 # RPATH here is a potential security issue. See the following for another
103 # example of this issue: https://code.google.com/p/gyp/issues/detail?id=315 104 # example of this issue: https://code.google.com/p/gyp/issues/detail?id=315
104 "-Wl,-R,\$ORIGIN/", 105 "-Wl,-R,\$ORIGIN/",
105 ] 106 ]
106 lib_dirs = [ root_build_dir ] 107 lib_dirs = [ root_build_dir ]
107 } 108 }
OLDNEW
« no previous file with comments | « no previous file | third_party/libc++abi/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698