third_party/libc++/BUILD.gn - Issue 1930753004: Always set symbol visibility when compiling with GCC / Clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libc++/BUILD.gn

Issue 1930753004: Always set symbol visibility when compiling with GCC / Clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/buildtools.git@master

Patch Set: sync Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/libc++/BUILD.gn

diff --git a/third_party/libc++/BUILD.gn b/third_party/libc++/BUILD.gn

index 48e18cb69fb8d74b4f9103f35b28aa97b34e8a9e..d44d75b1c331843039ef1bdf5a6f88435421b9ed 100644

--- a/third_party/libc++/BUILD.gn

+++ b/third_party/libc++/BUILD.gn

@@ -58,6 +58,7 @@ shared_library("libc++") {

":config",

"//build/config/compiler:no_chromium_code",

"//build/config/compiler:rtti",

+ "//build/config/gcc:symbol_visibility_default",

"//build/config/sanitizers:sanitizer_options_link_helper",

]

« no previous file with comments | « no previous file | third_party/libc++abi/BUILD.gn » ('j') | no next file with comments »