Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 19305004: Move implementation of SkFilterShader into its source file. (Closed)

Created:
7 years, 5 months ago by tfarina
Modified:
7 years, 5 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Move implementation of SkFilterShader into its source file. Since SkFilterShader has its own header file, makes more sense to have a separate source file to implement it rather than placing it in a "random" SkColorFilter.cpp file. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=10101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -131 lines) Patch
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkColorFilter.cpp View 2 chunks +1 line, -89 lines 0 comments Download
A + src/core/SkFilterShader.cpp View 1 chunk +10 lines, -42 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
7 years, 5 months ago (2013-07-15 23:33:13 UTC) #1
robertphillips
lgtm
7 years, 5 months ago (2013-07-15 23:58:00 UTC) #2
tfarina
7 years, 5 months ago (2013-07-16 13:05:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r10101 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698