Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1930233002: Fix URLRequestContext::CopyFrom in ios code (Closed)

Created:
4 years, 7 months ago by nharper
Modified:
4 years, 7 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix URLRequestContext::CopyFrom in ios code BUG=599049 Committed: https://crrev.com/4912248549948586848885a5b3eccff2ea16c104 Cr-Commit-Position: refs/heads/master@{#390694}

Patch Set 1 #

Patch Set 2 : Fix iOS compile; add NOTREACHED() #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm View 2 chunks +17 lines, -2 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 1 chunk +1 line, -2 lines 1 comment Download

Messages

Total messages: 10 (3 generated)
nharper
Now that https://codereview.chromium.org/1814543002/ has landed, this implements the same thing in the iOS code. This ...
4 years, 7 months ago (2016-04-28 23:58:15 UTC) #2
Ryan Hamilton
net/ lgtm. https://codereview.chromium.org/1930233002/diff/20001/net/url_request/url_request_http_job.cc File net/url_request/url_request_http_job.cc (right): https://codereview.chromium.org/1930233002/diff/20001/net/url_request/url_request_http_job.cc#newcode144 net/url_request/url_request_http_job.cc:144: NOTREACHED(); Woo hoo :>
4 years, 7 months ago (2016-04-29 03:57:46 UTC) #3
droger
lgtm, thanks!
4 years, 7 months ago (2016-04-29 08:28:26 UTC) #4
bzanotti
lgtm
4 years, 7 months ago (2016-04-29 08:40:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1930233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1930233002/20001
4 years, 7 months ago (2016-04-29 15:35:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 18:01:11 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:27:17 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4912248549948586848885a5b3eccff2ea16c104
Cr-Commit-Position: refs/heads/master@{#390694}

Powered by Google App Engine
This is Rietveld 408576698