net/url_request/url_request_http_job.cc - Issue 1930233002: Fix URLRequestContext::CopyFrom in ios code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_http_job.cc

Issue 1930233002: Fix URLRequestContext::CopyFrom in ios code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix iOS compile; add NOTREACHED() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_http_job.cc

diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc

index c38baaf0cf1c56ae6864bbd9f48d70ecaa5bc589..974b795cceef387150afe58440cf7742ad2b49e6 100644

--- a/net/url_request/url_request_http_job.cc

+++ b/net/url_request/url_request_http_job.cc

@@ -141,8 +141,7 @@ void LogChannelIDAndCookieStores(const GURL& url,

ephemerality = CID_EPHEMERAL_COOKIE_PERSISTENT;

}

} else if (cookie_store->IsEphemeral()) {

- // TODO(crbug.com/599049): Add NOTREACHED once this case doesn't happen on

- // iOS anymore.

+ NOTREACHED();

Ryan Hamilton 2016/04/29 03:57:46 Woo hoo :>

ephemerality = CID_PERSISTENT_COOKIE_EPHEMERAL;

} else if (cookie_store->GetChannelIDServiceID() == -1) {

ephemerality = PERSISTENT_UNKNOWN;

« no previous file with comments | « ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc ('k') | no next file » | no next file with comments »