Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: net/url_request/url_request_http_job.cc

Issue 1930233002: Fix URLRequestContext::CopyFrom in ios code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix iOS compile; add NOTREACHED() Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_http_job.h" 5 #include "net/url_request/url_request_http_job.h"
6 6
7 #include "base/base_switches.h" 7 #include "base/base_switches.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 NOTREACHED(); 134 NOTREACHED();
135 ephemerality = EPHEMERAL_MISMATCH; 135 ephemerality = EPHEMERAL_MISMATCH;
136 } 136 }
137 } else if (context->has_known_mismatched_cookie_store()) { 137 } else if (context->has_known_mismatched_cookie_store()) {
138 ephemerality = KNOWN_MISMATCH; 138 ephemerality = KNOWN_MISMATCH;
139 } else { 139 } else {
140 NOTREACHED(); 140 NOTREACHED();
141 ephemerality = CID_EPHEMERAL_COOKIE_PERSISTENT; 141 ephemerality = CID_EPHEMERAL_COOKIE_PERSISTENT;
142 } 142 }
143 } else if (cookie_store->IsEphemeral()) { 143 } else if (cookie_store->IsEphemeral()) {
144 // TODO(crbug.com/599049): Add NOTREACHED once this case doesn't happen on 144 NOTREACHED();
Ryan Hamilton 2016/04/29 03:57:46 Woo hoo :>
145 // iOS anymore.
146 ephemerality = CID_PERSISTENT_COOKIE_EPHEMERAL; 145 ephemerality = CID_PERSISTENT_COOKIE_EPHEMERAL;
147 } else if (cookie_store->GetChannelIDServiceID() == -1) { 146 } else if (cookie_store->GetChannelIDServiceID() == -1) {
148 ephemerality = PERSISTENT_UNKNOWN; 147 ephemerality = PERSISTENT_UNKNOWN;
149 } else if (cookie_store->GetChannelIDServiceID() == 148 } else if (cookie_store->GetChannelIDServiceID() ==
150 params->channel_id_service->GetUniqueID()) { 149 params->channel_id_service->GetUniqueID()) {
151 ephemerality = PERSISTENT_MATCH; 150 ephemerality = PERSISTENT_MATCH;
152 } else { 151 } else {
153 NOTREACHED(); 152 NOTREACHED();
154 ephemerality = PERSISTENT_MISMATCH; 153 ephemerality = PERSISTENT_MISMATCH;
155 } 154 }
(...skipping 1511 matching lines...) Expand 10 before | Expand all | Expand 10 after
1667 return override_response_headers_.get() ? 1666 return override_response_headers_.get() ?
1668 override_response_headers_.get() : 1667 override_response_headers_.get() :
1669 transaction_->GetResponseInfo()->headers.get(); 1668 transaction_->GetResponseInfo()->headers.get();
1670 } 1669 }
1671 1670
1672 void URLRequestHttpJob::NotifyURLRequestDestroyed() { 1671 void URLRequestHttpJob::NotifyURLRequestDestroyed() {
1673 awaiting_callback_ = false; 1672 awaiting_callback_ = false;
1674 } 1673 }
1675 1674
1676 } // namespace net 1675 } // namespace net
OLDNEW
« no previous file with comments | « ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698