Site Settings: Add Autoplay as a permission.

Site Settings: Add Autoplay as a permission.

BUG=604753
Committed: https://crrev.com/f7e0f4ed07692435b0235354a83ba4466988789b
Cr-Commit-Position: refs/heads/master@{#391210}

[Finnur, 2016-04-28 16:18:19]

finnur@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2016-04-29 23:54:44]

lgtm, but you might want to switch to the new finch approach as they might
require it when you try to submit the configs

https://codereview.chromium.org/1929983002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java
(right):

https://codereview.chromium.org/1929983002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java:59:
mAutoplayExperimentEnabled = autoplayTrialGroupName.equals("Enabled");
I believe the metrics teams are suggesting to use startsWith instead of equals. 
I also think they are preferring to use FeatureList instead of FieldTrials:

https://code.google.com/p/chromium/codesearch#chromium/src/base/feature_list.h

[Ted C, 2016-04-29 23:55:37]

On 2016/04/29 23:54:44, Ted C wrote:
> lgtm, but you might want to switch to the new finch approach as they might
> require it when you try to submit the configs
> 
>
https://codereview.chromium.org/1929983002/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java
> (right):
> 
>
https://codereview.chromium.org/1929983002/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java:59:
> mAutoplayExperimentEnabled = autoplayTrialGroupName.equals("Enabled");
> I believe the metrics teams are suggesting to use startsWith instead of
equals. 
> I also think they are preferring to use FeatureList instead of FieldTrials:
> 
> https://code.google.com/p/chromium/codesearch#chromium/src/base/feature_list.h

Also, make sure to run optimize-png-files.sh on the new images

[Finnur, 2016-05-03 11:51:13]

I've run optimize-png-files.sh on the images and changed to startsWith. 

As for the FeatureList comment: 

That field trial already exists -- landed a year ago, I'm told, so it sounds
unlikely to be asked to move to the new system. We can address this in a
follow-up if needed. Checking in.

[Finnur, 2016-05-03 11:51:28]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2016-05-03 11:51:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/1929983002/#ps40001
(title: "Sync to head")

[commit-bot: I haz the power, 2016-05-03 11:52:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929983002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929983002/40001

[mlamouri (slow - plz ping), 2016-05-03 12:28:36]

mlamouri@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-05-03 12:28:37]

FTR, this field trial has been around for a while. This is a new step in
autoplay experimentations but it did start roughly a year ago I believe.
Hopefully, we will not be asked to change legacy code but if we are, it should
probably be part of another CL.

[commit-bot: I haz the power, 2016-05-03 12:32:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-03 12:33:44]

Description was changed from

==========
Site Settings: Add Autoplay as a permission.

BUG=604753
==========

to

==========
Site Settings: Add Autoplay as a permission.

BUG=604753

Committed: https://crrev.com/f7e0f4ed07692435b0235354a83ba4466988789b
Cr-Commit-Position: refs/heads/master@{#391210}
==========

[commit-bot: I haz the power, 2016-05-03 12:33:45]

Patchset 3 (id:??) landed as
https://crrev.com/f7e0f4ed07692435b0235354a83ba4466988789b
Cr-Commit-Position: refs/heads/master@{#391210}