Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java

Issue 1929983002: Site Settings: Add Autoplay as a permission. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync to head Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
index f8f0b4a3ef20f9d590ca3373e40c843301ab8a9f..a95e25b51083e5bec5da6abaf95174975a23714b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
@@ -70,6 +70,7 @@ public class SingleWebsitePreferences extends PreferenceFragment
// Buttons:
public static final String PREF_RESET_SITE = "reset_site_button";
// Website permissions (if adding new, see hasPermissionsPreferences and resetSite below):
+ public static final String PREF_AUTOPLAY_PERMISSION = "autoplay_permission_list";
public static final String PREF_BACKGROUND_SYNC_PERMISSION = "background_sync_permission_list";
public static final String PREF_CAMERA_CAPTURE_PERMISSION = "camera_permission_list";
public static final String PREF_COOKIES_PERMISSION = "cookies_permission_list";
@@ -87,6 +88,7 @@ public class SingleWebsitePreferences extends PreferenceFragment
// All permissions from the permissions preference category must be listed here.
// TODO(mvanouwerkerk): Use this array in more places to reduce verbosity.
private static final String[] PERMISSION_PREFERENCE_KEYS = {
+ PREF_AUTOPLAY_PERMISSION,
PREF_BACKGROUND_SYNC_PERMISSION,
PREF_CAMERA_CAPTURE_PERMISSION,
PREF_COOKIES_PERMISSION,
@@ -300,6 +302,8 @@ public class SingleWebsitePreferences extends PreferenceFragment
}
} else if (PREF_RESET_SITE.equals(preference.getKey())) {
preference.setOnPreferenceClickListener(this);
+ } else if (PREF_AUTOPLAY_PERMISSION.equals(preference.getKey())) {
+ setUpListPreference(preference, mSite.getAutoplayPermission());
} else if (PREF_BACKGROUND_SYNC_PERMISSION.equals(preference.getKey())) {
setUpListPreference(preference, mSite.getBackgroundSyncPermission());
} else if (PREF_CAMERA_CAPTURE_PERMISSION.equals(preference.getKey())) {
@@ -529,6 +533,8 @@ public class SingleWebsitePreferences extends PreferenceFragment
private int getContentSettingsTypeFromPreferenceKey(String preferenceKey) {
switch (preferenceKey) {
+ case PREF_AUTOPLAY_PERMISSION:
+ return ContentSettingsType.CONTENT_SETTINGS_TYPE_AUTOPLAY;
case PREF_BACKGROUND_SYNC_PERMISSION:
return ContentSettingsType.CONTENT_SETTINGS_TYPE_BACKGROUND_SYNC;
case PREF_CAMERA_CAPTURE_PERMISSION:
@@ -591,7 +597,9 @@ public class SingleWebsitePreferences extends PreferenceFragment
@Override
public boolean onPreferenceChange(Preference preference, Object newValue) {
ContentSetting permission = ContentSetting.fromString((String) newValue);
- if (PREF_BACKGROUND_SYNC_PERMISSION.equals(preference.getKey())) {
+ if (PREF_AUTOPLAY_PERMISSION.equals(preference.getKey())) {
+ mSite.setAutoplayPermission(permission);
+ } else if (PREF_BACKGROUND_SYNC_PERMISSION.equals(preference.getKey())) {
mSite.setBackgroundSyncPermission(permission);
} else if (PREF_CAMERA_CAPTURE_PERMISSION.equals(preference.getKey())) {
mSite.setCameraPermission(permission);
@@ -654,6 +662,7 @@ public class SingleWebsitePreferences extends PreferenceFragment
}
// Clear the permissions.
+ mSite.setAutoplayPermission(ContentSetting.DEFAULT);
mSite.setBackgroundSyncPermission(ContentSetting.DEFAULT);
mSite.setCameraPermission(ContentSetting.DEFAULT);
mSite.setCookiePermission(ContentSetting.DEFAULT);

Powered by Google App Engine
This is Rietveld 408576698