DescriptionPopulate download_file_types proto and filter it for each platform. Except for a few extensions that were missing in the old code, these data retain the same settings as the old .cc files.
Also:
* Move ping_settings out of platform_settings. It'll have one value for all platforms.
* Allow for an empty platform_settings and fill in the default_file_type's values. This makes the config shorter.
* Add UMA values for two missing extensions and one for when we can't load the list at all.
The data were generated by joining kDownloadFileTypes (from download_extensions.cc) and kSafeBrowsingFileTypes (from download_protection_util.cc) in a one-off conversion. The join aimed to minimize the number of items in platform_settings by setting a default when those settings were used by the majority of platforms for that file type.
I left "ping_setting" set in all types (rather than use a default of FULL_PING) since it wouldn't be obvious in that state what the default value was.
The conversion was done with //depot/google3/experimental/users/nparker/extensions/dump_new_proto.cc
BUG=596555
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/59a573bc29379c9b316b464e4fe838d2ef644a93
Cr-Commit-Position: refs/heads/master@{#393114}
Patch Set 1 #Patch Set 2 : Add real types, move ping_settings out of platform_settings #Patch Set 3 : Update docs, add is_archive #Patch Set 4 : nits in comments #Patch Set 5 : rebase #
Total comments: 2
Patch Set 6 : Add MacOS-specialized types, flip default to ALLOW_AUTO_OPEN, and add OS-specific tests #Patch Set 7 : Fix uma_value for ad and run, add missing entries for pdf, apk, torrent. #Patch Set 8 : fix gyp build #Patch Set 9 : (rebase) #Patch Set 10 : fix chromeos detection again #
Total comments: 6
Patch Set 11 : Fixes to comments and .gyp per thestig #Patch Set 12 : Switch to grouped extensions and add comments #
Total comments: 10
Patch Set 13 : reorder ascipb per asanka's comments #Dependent Patchsets: Messages
Total messages: 34 (17 generated)
|