Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: chrome/browser/resources/safe_browsing/BUILD.gn

Issue 1929693003: Populate download_file_types proto and filter it for each platform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@file_type_polices2
Patch Set: reorder ascipb per asanka's comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/safe_browsing/README.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/safe_browsing/BUILD.gn
diff --git a/chrome/browser/resources/safe_browsing/BUILD.gn b/chrome/browser/resources/safe_browsing/BUILD.gn
index 9a039aee4f962a9e17bf47fa8d7d325ff32a6e6f..679335803db461921aaf37f3607a53d0120c2b38 100644
--- a/chrome/browser/resources/safe_browsing/BUILD.gn
+++ b/chrome/browser/resources/safe_browsing/BUILD.gn
@@ -14,6 +14,23 @@ action("make_file_types_protobuf") {
python_path_root = "$root_build_dir/pyproto"
python_path_safe_browsing = "$python_path_root/chrome/common/safe_browsing"
+ # Pick an architecture to generate for. These string match those
+ # in the python script.
+ if (is_android) {
+ target_arch = "android"
+ } else if (is_chromeos) {
+ target_arch = "chromeos"
+ } else if (is_win) {
+ target_arch = "win"
+ } else if (is_mac) {
+ target_arch = "mac"
+ } else if (is_linux) {
+ target_arch = "linux"
+ } else {
+ # This will cause the script to fail.
+ target_arch = "unknown_target_arch"
+ }
+
inputs = [
script,
input_filename,
@@ -31,6 +48,8 @@ action("make_file_types_protobuf") {
args = [
"-w",
+ "-t",
+ target_arch,
"-i",
rebase_path(input_filename, root_build_dir),
"-o",
« no previous file with comments | « no previous file | chrome/browser/resources/safe_browsing/README.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698