Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1929293002: Revert of Remove more dead code after Object.observe removal (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, adamk
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove more dead code after Object.observe removal (patchset #5 id:80001 of https://codereview.chromium.org/1904313004/ ) Reason for revert: [Sheriff] Looks like this breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/6442 Original issue's description: > Remove more dead code after Object.observe removal > > This moves __{define,lookup}{Getter,Setter}__ to builtins.cc to free up the JavaScript implementation of DefineOwnProperty for deletion. TBR=verwaest@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/819371c6281c2dbe7646b7a691e4d7bb635c460a Cr-Commit-Position: refs/heads/master@{#35886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -199 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/builtins.h View 2 chunks +4 lines, -8 lines 0 comments Download
M src/builtins.cc View 2 chunks +6 lines, -128 lines 0 comments Download
M src/contexts.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/isolate-inl.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/js/array.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/js/macros.py View 2 chunks +11 lines, -0 lines 0 comments Download
M src/js/prologue.js View 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/v8natives.js View 4 chunks +52 lines, -4 lines 0 comments Download
M src/objects.h View 5 chunks +23 lines, -8 lines 0 comments Download
M src/objects.cc View 5 chunks +219 lines, -14 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +103 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M test/mjsunit/regress/regress-1240.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mozilla/mozilla.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of Remove more dead code after Object.observe removal
4 years, 7 months ago (2016-04-29 06:28:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929293002/1
4 years, 7 months ago (2016-04-29 06:28:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 06:29:06 UTC) #4
Jakob Kummerow
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1932163002/ by jkummerow@chromium.org. ...
4 years, 7 months ago (2016-04-29 07:35:45 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/819371c6281c2dbe7646b7a691e4d7bb635c460a
Cr-Commit-Position: refs/heads/master@{#35886}

Powered by Google App Engine
This is Rietveld 408576698