Revert of Fix ReadPixels from float fbo buffer in ES2/WebGL1.

Revert of Fix ReadPixels from float fbo buffer in ES2/WebGL1. (patchset #2 id:20001 of https://codereview.chromium.org/1927593005/ )

Reason for revert:
Reason: crbug.com/607936

(GLReadbackTest.ReadPixelsFloat fails on "Lollipop Tablet Tester")

Original issue's description:
> Fix ReadPixels from float fbo buffer in ES2/WebGL1.
>
> This CL change the default format/type from RGBA/UNSIGNED_BYTE to RGBA/FLOAT.
>
> Also, simplify querying IMPLMENTATION_READ_COLOR_FORMAT/TYPE by
> always calling down to the driver (even if the two enums are not
> supported) and fall back to internal decision if a GL error is
> generated.
>
> BUG=607283
> TEST=webgl_conformance,webgl2_conformance
> R=piman@chromium.org,kbr@chromium.org,bajones@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=bajones@chromium.org,kbr@chromium.org,piman@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607283
Committed: https://crrev.com/73e7b2db99c6340e221ca596bb9f85b401a84b16
Cr-Commit-Position: refs/heads/master@{#390684}

[pasko, 2016-04-29 17:26:17]

Created Revert of Fix ReadPixels from float fbo buffer in ES2/WebGL1.

[commit-bot: I haz the power, 2016-04-29 17:26:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929203003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929203003/1

[commit-bot: I haz the power, 2016-04-29 17:27:14]

Description was changed from

==========
Revert of Fix ReadPixels from float fbo buffer in ES2/WebGL1. (patchset #2
id:20001 of https://codereview.chromium.org/1927593005/ )

Reason for revert:
Reason: crbug.com/607936

(GLReadbackTest.ReadPixelsFloat fails on "Lollipop Tablet Tester")

Original issue's description:
> Fix ReadPixels from float fbo buffer in ES2/WebGL1.
> 
> This CL change the default format/type from RGBA/UNSIGNED_BYTE to RGBA/FLOAT.
> 
> Also, simplify querying IMPLMENTATION_READ_COLOR_FORMAT/TYPE by
> always calling down to the driver (even if the two enums are not
> supported) and fall back to internal decision if a GL error is
> generated.
> 
> BUG=607283
> TEST=webgl_conformance,webgl2_conformance
> R=piman@chromium.org,kbr@chromium.org,bajones@chromium.org
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=bajones@chromium.org,kbr@chromium.org,piman@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607283
==========

to

==========
Revert of Fix ReadPixels from float fbo buffer in ES2/WebGL1. (patchset #2
id:20001 of https://codereview.chromium.org/1927593005/ )

Reason for revert:
Reason: crbug.com/607936

(GLReadbackTest.ReadPixelsFloat fails on "Lollipop Tablet Tester")

Original issue's description:
> Fix ReadPixels from float fbo buffer in ES2/WebGL1.
> 
> This CL change the default format/type from RGBA/UNSIGNED_BYTE to RGBA/FLOAT.
> 
> Also, simplify querying IMPLMENTATION_READ_COLOR_FORMAT/TYPE by
> always calling down to the driver (even if the two enums are not
> supported) and fall back to internal decision if a GL error is
> generated.
> 
> BUG=607283
> TEST=webgl_conformance,webgl2_conformance
> R=piman@chromium.org,kbr@chromium.org,bajones@chromium.org
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=bajones@chromium.org,kbr@chromium.org,piman@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607283
==========

[commit-bot: I haz the power, 2016-04-29 17:27:14]

Committed patchset #1 (id:1)

[Zhenyao Mo, 2016-04-29 17:55:13]

No, this CL should not be merged, but the test should be marked as fail on that
device (or ANDROID).

[Zhenyao Mo, 2016-04-29 18:10:24]

I will reland the original CL with this test disabled on ANDROID.  Then we can
dig why it fails on this specific hardware - most likely a driver bug.

[pasko, 2016-04-29 18:37:44]

On 2016/04/29 18:10:24, Zhenyao Mo wrote:
> I will reland the original CL with this test disabled on ANDROID.  Then we can
> dig why it fails on this specific hardware - most likely a driver bug.

sgtm, thanks

[commit-bot: I haz the power, 2016-04-30 17:26:48]

Patchset 1 (id:??) landed as
https://crrev.com/73e7b2db99c6340e221ca596bb9f85b401a84b16
Cr-Commit-Position: refs/heads/master@{#390684}

[commit-bot: I haz the power, 2016-04-30 18:01:14]

Description was changed from

==========
Revert of Fix ReadPixels from float fbo buffer in ES2/WebGL1. (patchset #2
id:20001 of https://codereview.chromium.org/1927593005/ )

Reason for revert:
Reason: crbug.com/607936

(GLReadbackTest.ReadPixelsFloat fails on "Lollipop Tablet Tester")

Original issue's description:
> Fix ReadPixels from float fbo buffer in ES2/WebGL1.
> 
> This CL change the default format/type from RGBA/UNSIGNED_BYTE to RGBA/FLOAT.
> 
> Also, simplify querying IMPLMENTATION_READ_COLOR_FORMAT/TYPE by
> always calling down to the driver (even if the two enums are not
> supported) and fall back to internal decision if a GL error is
> generated.
> 
> BUG=607283
> TEST=webgl_conformance,webgl2_conformance
> R=piman@chromium.org,kbr@chromium.org,bajones@chromium.org
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=bajones@chromium.org,kbr@chromium.org,piman@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607283
==========

to

==========
Revert of Fix ReadPixels from float fbo buffer in ES2/WebGL1. (patchset #2
id:20001 of https://codereview.chromium.org/1927593005/ )

Reason for revert:
Reason: crbug.com/607936

(GLReadbackTest.ReadPixelsFloat fails on "Lollipop Tablet Tester")

Original issue's description:
> Fix ReadPixels from float fbo buffer in ES2/WebGL1.
>
> This CL change the default format/type from RGBA/UNSIGNED_BYTE to RGBA/FLOAT.
>
> Also, simplify querying IMPLMENTATION_READ_COLOR_FORMAT/TYPE by
> always calling down to the driver (even if the two enums are not
> supported) and fall back to internal decision if a GL error is
> generated.
>
> BUG=607283
> TEST=webgl_conformance,webgl2_conformance
> R=piman@chromium.org,kbr@chromium.org,bajones@chromium.org
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=bajones@chromium.org,kbr@chromium.org,piman@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=607283

Committed: https://crrev.com/73e7b2db99c6340e221ca596bb9f85b401a84b16
Cr-Commit-Position: refs/heads/master@{#390684}
==========