gpu/command_buffer/tests/gl_readback_unittest.cc - Issue 1929203003: Revert of Fix ReadPixels from float fbo buffer in ES2/WebGL1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/tests/gl_readback_unittest.cc

Issue 1929203003: Revert of Fix ReadPixels from float fbo buffer in ES2/WebGL1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/tests/gl_readback_unittest.cc

diff --git a/gpu/command_buffer/tests/gl_readback_unittest.cc b/gpu/command_buffer/tests/gl_readback_unittest.cc

index fe088c12d3a0c8ec67da21a7eacaed902d1474cb..c9038dc9973f6e632a9bb4ebe95bf39b5e801cbb 100644

--- a/gpu/command_buffer/tests/gl_readback_unittest.cc

+++ b/gpu/command_buffer/tests/gl_readback_unittest.cc

@@ -141,14 +141,7 @@

return shader;

}

-// TODO(zmo): ReadPixels with float type isn't implemented in ANGLE ES2

-// backend. crbug.com/607283.

-#if defined(OS_WIN)

-#define MAYBE_ReadPixelsFloat DISABLED_ReadPixelsFloat

-#else

-#define MAYBE_ReadPixelsFloat ReadPixelsFloat

-#endif

-TEST_F(GLReadbackTest, MAYBE_ReadPixelsFloat) {

+TEST_F(GLReadbackTest, ReadPixelsFloat) {

const GLsizei kTextureSize = 4;

const GLfloat kDrawColor[4] = { -10.9f, 0.5f, 10.5f, 100.12f };

const GLfloat kEpsilon = 0.01f;