Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1928443002: Remove element related checks for PseudoDisabled css class. (Closed)

Created:
4 years, 7 months ago by ramya.v
Modified:
4 years, 7 months ago
Reviewers:
tkent
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove element related checks for PseudoDisabled css class. No behavior changes. BUG=None Committed: https://crrev.com/6f571f023efd60fb5f1231a78765a000b7f27985 Cr-Commit-Position: refs/heads/master@{#390007}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated as per review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ramya.v
PTAL! Thanks
4 years, 7 months ago (2016-04-27 04:24:06 UTC) #2
tkent
https://codereview.chromium.org/1928443002/diff/1/third_party/WebKit/Source/core/css/SelectorChecker.cpp File third_party/WebKit/Source/core/css/SelectorChecker.cpp (left): https://codereview.chromium.org/1928443002/diff/1/third_party/WebKit/Source/core/css/SelectorChecker.cpp#oldcode833 third_party/WebKit/Source/core/css/SelectorChecker.cpp:833: // Can it be true for elements not in ...
4 years, 7 months ago (2016-04-27 04:40:43 UTC) #3
ramya.v
Updated as per review comments. PTAL! Thanks https://codereview.chromium.org/1928443002/diff/1/third_party/WebKit/Source/core/css/SelectorChecker.cpp File third_party/WebKit/Source/core/css/SelectorChecker.cpp (left): https://codereview.chromium.org/1928443002/diff/1/third_party/WebKit/Source/core/css/SelectorChecker.cpp#oldcode833 third_party/WebKit/Source/core/css/SelectorChecker.cpp:833: // Can ...
4 years, 7 months ago (2016-04-27 05:41:35 UTC) #5
tkent
lgtm
4 years, 7 months ago (2016-04-27 05:42:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1928443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1928443002/20001
4 years, 7 months ago (2016-04-27 05:42:24 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 06:55:48 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 06:57:33 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f571f023efd60fb5f1231a78765a000b7f27985
Cr-Commit-Position: refs/heads/master@{#390007}

Powered by Google App Engine
This is Rietveld 408576698