Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: third_party/WebKit/Source/core/css/SelectorChecker.cpp

Issue 1928443002: Remove element related checks for PseudoDisabled css class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated as per review comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/SelectorChecker.cpp
diff --git a/third_party/WebKit/Source/core/css/SelectorChecker.cpp b/third_party/WebKit/Source/core/css/SelectorChecker.cpp
index 5cc7f0fcfee067de6833d291f67f2f2dec7c83ea..3416c2386789fce0db221a12c9e35cd4d44c2431 100644
--- a/third_party/WebKit/Source/core/css/SelectorChecker.cpp
+++ b/third_party/WebKit/Source/core/css/SelectorChecker.cpp
@@ -829,11 +829,7 @@ bool SelectorChecker::checkPseudoClass(const SelectorCheckingContext& context, M
case CSSSelector::PseudoDefault:
return element.matchesDefaultPseudoClass();
case CSSSelector::PseudoDisabled:
- // TODO(esprehn): Why not just always return isDisabledFormControl()?
- // Can it be true for elements not in the list below?
- if (element.isFormControlElement() || isHTMLOptionElement(element) || isHTMLOptGroupElement(element))
- return element.isDisabledFormControl();
- break;
+ return element.isDisabledFormControl();
case CSSSelector::PseudoReadOnly:
return element.matchesReadOnlyPseudoClass();
case CSSSelector::PseudoReadWrite:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698