Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: third_party/WebKit/Source/core/css/SelectorChecker.cpp

Issue 1928443002: Remove element related checks for PseudoDisabled css class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated as per review comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 811 matching lines...) Expand 10 before | Expand all | Expand 10 after
822 if (InspectorInstrumentation::forcePseudoState(&element, CSSSelector::Ps eudoActive)) 822 if (InspectorInstrumentation::forcePseudoState(&element, CSSSelector::Ps eudoActive))
823 return true; 823 return true;
824 return element.active(); 824 return element.active();
825 case CSSSelector::PseudoEnabled: 825 case CSSSelector::PseudoEnabled:
826 return element.matchesEnabledPseudoClass(); 826 return element.matchesEnabledPseudoClass();
827 case CSSSelector::PseudoFullPageMedia: 827 case CSSSelector::PseudoFullPageMedia:
828 return element.document().isMediaDocument(); 828 return element.document().isMediaDocument();
829 case CSSSelector::PseudoDefault: 829 case CSSSelector::PseudoDefault:
830 return element.matchesDefaultPseudoClass(); 830 return element.matchesDefaultPseudoClass();
831 case CSSSelector::PseudoDisabled: 831 case CSSSelector::PseudoDisabled:
832 // TODO(esprehn): Why not just always return isDisabledFormControl()? 832 return element.isDisabledFormControl();
833 // Can it be true for elements not in the list below?
834 if (element.isFormControlElement() || isHTMLOptionElement(element) || is HTMLOptGroupElement(element))
835 return element.isDisabledFormControl();
836 break;
837 case CSSSelector::PseudoReadOnly: 833 case CSSSelector::PseudoReadOnly:
838 return element.matchesReadOnlyPseudoClass(); 834 return element.matchesReadOnlyPseudoClass();
839 case CSSSelector::PseudoReadWrite: 835 case CSSSelector::PseudoReadWrite:
840 return element.matchesReadWritePseudoClass(); 836 return element.matchesReadWritePseudoClass();
841 case CSSSelector::PseudoOptional: 837 case CSSSelector::PseudoOptional:
842 return element.isOptionalFormControl(); 838 return element.isOptionalFormControl();
843 case CSSSelector::PseudoRequired: 839 case CSSSelector::PseudoRequired:
844 return element.isRequiredFormControl(); 840 return element.isRequiredFormControl();
845 case CSSSelector::PseudoValid: 841 case CSSSelector::PseudoValid:
846 if (m_mode == ResolvingStyle) 842 if (m_mode == ResolvingStyle)
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
1139 } 1135 }
1140 1136
1141 bool SelectorChecker::matchesFocusPseudoClass(const Element& element) 1137 bool SelectorChecker::matchesFocusPseudoClass(const Element& element)
1142 { 1138 {
1143 if (InspectorInstrumentation::forcePseudoState(const_cast<Element*>(&element ), CSSSelector::PseudoFocus)) 1139 if (InspectorInstrumentation::forcePseudoState(const_cast<Element*>(&element ), CSSSelector::PseudoFocus))
1144 return true; 1140 return true;
1145 return element.focused() && isFrameFocused(element); 1141 return element.focused() && isFrameFocused(element);
1146 } 1142 }
1147 1143
1148 } // namespace blink 1144 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698