Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 192833005: Silence git-hooks/pre-commit in the absence of .gitmodules. (Closed)

Created:
6 years, 9 months ago by Ami GONE FROM CHROMIUM
Modified:
6 years, 9 months ago
Reviewers:
szager1
CC:
chromium-reviews
Visibility:
Public.

Description

Silence git-hooks/pre-commit in the absence of .gitmodules. Other projects use depot_tools (which pulls in this hook) and chromium's build/ (where the hook lives) but don't use git modules (e.g. webrtc).

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M git-hooks/pre-commit View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 8 (0 generated)
Ami GONE FROM CHROMIUM
@szager: PTAL. https://codereview.chromium.org/192833005/diff/20001/git-hooks/pre-commit File git-hooks/pre-commit (right): https://codereview.chromium.org/192833005/diff/20001/git-hooks/pre-commit#newcode26 git-hooks/pre-commit:26: if [[ -n "$(git ls-files .gitmodules)" && ...
6 years, 9 months ago (2014-03-10 19:04:48 UTC) #1
Ami GONE FROM CHROMIUM
szager: ping?
6 years, 9 months ago (2014-03-17 03:49:16 UTC) #2
szager1
Sorry for the delay lgtm, thanks
6 years, 9 months ago (2014-03-17 04:17:27 UTC) #3
Ami GONE FROM CHROMIUM
The CQ bit was checked by fischman@chromium.org
6 years, 9 months ago (2014-03-17 04:18:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/192833005/20001
6 years, 9 months ago (2014-03-17 04:18:26 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 04:22:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-17 04:22:42 UTC) #7
Ami GONE FROM CHROMIUM
6 years, 9 months ago (2014-03-17 16:37:58 UTC) #8
Base URL for this issue was busted (b/c uploaded from a non-chromium checkout). 
Closing this in favor of https://codereview.chromium.org/196413021.

Powered by Google App Engine
This is Rietveld 408576698