Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 196413021: Silence git-hooks/pre-commit in the absence of .gitmodules. (Closed)

Created:
6 years, 9 months ago by Ami GONE FROM CHROMIUM
Modified:
6 years, 9 months ago
Reviewers:
szager1
CC:
chromium-reviews
Visibility:
Public.

Description

Silence git-hooks/pre-commit in the absence of .gitmodules. Other projects use depot_tools (which pulls in this hook) and chromium's build/ (where the hook lives) but don't use git modules (e.g. webrtc). TBR=szager@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/git-hooks/pre-commit View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Ami GONE FROM CHROMIUM
TBRing on the strength of the LGTM given in https://codereview.chromium.org/192833005/
6 years, 9 months ago (2014-03-17 16:38:43 UTC) #1
Ami GONE FROM CHROMIUM
The CQ bit was checked by fischman@chromium.org
6 years, 9 months ago (2014-03-17 16:38:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/196413021/1
6 years, 9 months ago (2014-03-17 16:38:57 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 18:36:41 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-17 18:36:43 UTC) #5
Ami GONE FROM CHROMIUM
The CQ bit was checked by fischman@chromium.org
6 years, 9 months ago (2014-03-17 18:49:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/196413021/1
6 years, 9 months ago (2014-03-17 18:49:55 UTC) #7
commit-bot: I haz the power
Change committed as 257470
6 years, 9 months ago (2014-03-17 18:50:48 UTC) #8
davve
6 years, 9 months ago (2014-03-19 08:52:06 UTC) #9
Message was sent while issue was closed.
On 2014/03/17 18:50:48, I haz the power (commit-bot) wrote:
> Change committed as 257470

FYI, I get:

build/git-hooks/pre-commit: 26: build/git-hooks/pre-commit: [[: not found

[[ a bash:ism, AFAIK. My sh is dash (on Debian). Submitted
https://codereview.chromium.org/203463010/ to address.

Powered by Google App Engine
This is Rietveld 408576698