Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: services/dart/dart_tracing.h

Issue 1928183002: Use TraceProviderRegistry in //services/dart/dart_tracing.*. (Closed) Base URL: https://github.com/domokit/mojo.git@work787_trace_provider_registry_2
Patch Set: gah Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/dart/dart_tracing.h
diff --git a/services/dart/dart_tracing.h b/services/dart/dart_tracing.h
index 1b2135e1e788f8b9c283a20ff96db362d774dd95..d9a669c8528162adcd1d5cb462760721833814ee 100644
--- a/services/dart/dart_tracing.h
+++ b/services/dart/dart_tracing.h
@@ -7,7 +7,6 @@
#include "base/trace_event/trace_event.h"
#include "mojo/common/tracing_impl.h"
-#include "mojo/public/cpp/application/service_provider_impl.h"
#include "mojo/public/cpp/bindings/interface_request.h"
#include "mojo/services/tracing/interfaces/tracing.mojom.h"
@@ -42,24 +41,16 @@ class DartTraceProvider : public tracing::TraceProvider {
DISALLOW_COPY_AND_ASSIGN(DartTraceProvider);
};
-class DartTracingImpl :
- public mojo::InterfaceFactory<tracing::TraceProvider> {
+class DartTracingImpl {
public:
- DartTracingImpl();
- ~DartTracingImpl() override;
+ DartTracingImpl();
+ ~DartTracingImpl();
- // This connects to the tracing service and registers ourselves to provide
- // tracing data on demand.
- void Initialize(mojo::ApplicationImpl* app);
+ // This connects to the tracing service and registers ourselves to provide
+ // tracing data on demand.
+ void Initialize(mojo::ApplicationImpl* app);
- private:
- // InterfaceFactory<tracing::TraceProvider> implementation.
- void Create(mojo::ApplicationConnection* connection,
- mojo::InterfaceRequest<tracing::TraceProvider> request) override;
private:
- // Used to provide services *to* mojo:tracing.
- mojo::ServiceProviderImpl outgoing_sp_for_tracing_service_;
-
DartTraceProvider provider_impl_;
DISALLOW_COPY_AND_ASSIGN(DartTracingImpl);

Powered by Google App Engine
This is Rietveld 408576698