Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1928083002: Ignore sink start attempts when no frames are present. (Closed)

Created:
4 years, 7 months ago by DaleCurtis
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2717
Target Ref:
refs/pending/branch-heads/2717
Project:
chromium
Visibility:
Public.

Description

Ignore sink start attempts when no frames are present. Buffering state changes may be in flight at the time of the sink start attempt by RendererImpl. Some of these may have removed all the frames in the queue. Ignore sink start in this case. BUG=601066, 606733 TEST=new unittest Review URL: https://codereview.chromium.org/1924513003 Cr-Commit-Position: refs/heads/master@{#389933} (cherry picked from commit c7aeeb2d491234bfaf07e1ef4e314da09a1f57d3) Committed: https://chromium.googlesource.com/chromium/src/+/a71021d6d8102712a613f19afd8ad7eb36ab2563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M media/base/null_video_sink.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/null_video_sink_unittest.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M media/renderers/video_renderer_impl.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years, 7 months ago (2016-04-28 18:13:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a71021d6d8102712a613f19afd8ad7eb36ab2563.

Powered by Google App Engine
This is Rietveld 408576698