Issue 1928083002: Ignore sink start attempts when no frames are present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1928083002: Ignore sink start attempts when no frames are present. (Closed)

Created:
4 years, 7 months ago by DaleCurtis

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2717

Target Ref:
refs/pending/branch-heads/2717

Project:
chromium

Visibility:
Public.

Ignore sink start attempts when no frames are present. Buffering state changes may be in flight at the time of the sink start attempt by RendererImpl. Some of these may have removed all the frames in the queue. Ignore sink start in this case. BUG=601066, 606733 TEST=new unittest Review URL: https://codereview.chromium.org/1924513003 Cr-Commit-Position: refs/heads/master@{#389933} (cherry picked from commit c7aeeb2d491234bfaf07e1ef4e314da09a1f57d3) Committed: https://chromium.googlesource.com/chromium/src/+/a71021d6d8102712a613f19afd8ad7eb36ab2563

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -6 lines)			Patch
M	media/base/null_video_sink.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/base/null_video_sink_unittest.cc	View	3 chunks	+7 lines, -4 lines	0 comments	Download
M	media/renderers/video_renderer_impl.cc	View	1 chunk	+11 lines, -2 lines	0 comments	Download
M	media/renderers/video_renderer_impl_unittest.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

DaleCurtis

4 years, 7 months ago (2016-04-28 18:13:38 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a71021d6d8102712a613f19afd8ad7eb36ab2563.