Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: media/base/null_video_sink.cc

Issue 1928083002: Ignore sink start attempts when no frames are present. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2717
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/null_video_sink_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/null_video_sink.cc
diff --git a/media/base/null_video_sink.cc b/media/base/null_video_sink.cc
index 0d9746d3620af61fcf3ffba3a4b50982c026e024..f8471056c99c85f6b9f185d5c046adbe05ade819 100644
--- a/media/base/null_video_sink.cc
+++ b/media/base/null_video_sink.cc
@@ -56,6 +56,7 @@ void NullVideoSink::CallRender() {
const base::TimeTicks end_of_interval = current_render_time_ + interval_;
scoped_refptr<VideoFrame> new_frame = callback_->Render(
current_render_time_, end_of_interval, background_render_);
+ DCHECK(new_frame);
const bool is_new_frame = new_frame != last_frame_;
last_frame_ = new_frame;
if (is_new_frame && !new_frame_cb_.is_null())
« no previous file with comments | « no previous file | media/base/null_video_sink_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698