Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1924513003: Ignore sink start attempts when no frames are present. (Closed)

Created:
4 years, 8 months ago by DaleCurtis
Modified:
4 years, 8 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore sink start attempts when no frames are present. Buffering state changes may be in flight at the time of the sink start attempt by RendererImpl. Some of these may have removed all the frames in the queue. Ignore sink start in this case. BUG=601066, 606733 TEST=new unittest Committed: https://crrev.com/c7aeeb2d491234bfaf07e1ef4e314da09a1f57d3 Cr-Commit-Position: refs/heads/master@{#389933}

Patch Set 1 #

Patch Set 2 : Add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M media/base/null_video_sink.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/base/null_video_sink_unittest.cc View 1 3 chunks +7 lines, -4 lines 0 comments Download
M media/renderers/video_renderer_impl.cc View 1 1 chunk +11 lines, -2 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
DaleCurtis
Will land a test in a followup once I figure out how, but this will ...
4 years, 8 months ago (2016-04-26 18:02:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924513003/1
4 years, 8 months ago (2016-04-26 18:42:56 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/151023)
4 years, 8 months ago (2016-04-26 19:13:01 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924513003/20001
4 years, 8 months ago (2016-04-26 19:34:23 UTC) #10
xhwang
lgtm
4 years, 8 months ago (2016-04-26 21:20:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1924513003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1924513003/20001
4 years, 8 months ago (2016-04-26 21:20:58 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 22:52:56 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 22:54:18 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c7aeeb2d491234bfaf07e1ef4e314da09a1f57d3
Cr-Commit-Position: refs/heads/master@{#389933}

Powered by Google App Engine
This is Rietveld 408576698