Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1927983002: Fixed Back/Forward buttons to not hide ink drop when long press shows drop down menu. (Closed)

Created:
4 years, 7 months ago by bruthig
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fixed Back/Forward buttons to not hide ink drop when long press shows drop down menu. Some CustomButtons should hide the ink drop when showing the context menu (i.e. Bookmark menu buttons) and some should not (i.e. the Back/ Forward toolbar buttons). BUG=602754 TEST=CustomButton.HideInkDropWhenShowingContextMenu TEST=CustomButton.DontHideInkDropWhenShowingContextMenu Review URL: https://codereview.chromium.org/1920783003 Cr-Commit-Position: refs/heads/master@{#389629} (cherry picked from commit b1068403be34a565e8be1aafe2fc7a2f0ba3f3eb) Committed: https://chromium.googlesource.com/chromium/src/+/f71636d278a0eaa4ed6818075b8ad3a05c204e12

Patch Set 1 #

Patch Set 2 : Changed base::WrapUnique() to make_scoped_ptr(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/controls/button/custom_button.h View 2 chunks +10 lines, -0 lines 0 comments Download
M ui/views/controls/button/custom_button.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/button/custom_button_unittest.cc View 1 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
bruthig
4 years, 7 months ago (2016-04-28 15:22:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f71636d278a0eaa4ed6818075b8ad3a05c204e12.

Powered by Google App Engine
This is Rietveld 408576698