Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1920783003: Fixed Back/Forward buttons to not hide ink drop when long press shows drop down menu. (Closed)

Created:
4 years, 8 months ago by bruthig
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed Back/Forward buttons to not hide ink drop when long press shows drop down menu. Some CustomButtons should hide the ink drop when showing the context menu (i.e. Bookmark menu buttons) and some should not (i.e. the Back/ Forward toolbar buttons). BUG=602754 TEST=CustomButton.HideInkDropWhenShowingContextMenu TEST=CustomButton.DontHideInkDropWhenShowingContextMenu Committed: https://crrev.com/b1068403be34a565e8be1aafe2fc7a2f0ba3f3eb Cr-Commit-Position: refs/heads/master@{#389629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/controls/button/custom_button.h View 2 chunks +10 lines, -0 lines 0 comments Download
M ui/views/controls/button/custom_button.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/button/custom_button_unittest.cc View 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
bruthig
sky@, can you please take a look?
4 years, 8 months ago (2016-04-25 21:29:48 UTC) #2
sky
LGTM
4 years, 8 months ago (2016-04-25 22:26:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920783003/1
4 years, 8 months ago (2016-04-25 22:27:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 00:17:09 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 00:18:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1068403be34a565e8be1aafe2fc7a2f0ba3f3eb
Cr-Commit-Position: refs/heads/master@{#389629}

Powered by Google App Engine
This is Rietveld 408576698