Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3606)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_view.cc

Issue 1927983002: Fixed Back/Forward buttons to not hide ink drop when long press shows drop down menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Changed base::WrapUnique() to make_scoped_ptr(). Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/button/custom_button.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/toolbar_view.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_view.cc b/chrome/browser/ui/views/toolbar/toolbar_view.cc
index 98b84ce5c6fe502411ba5d1955943557a9ac5801..2e0e868c1a9994108b904f5b52c969d1f03ac7e2 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_view.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_view.cc
@@ -177,6 +177,7 @@ void ToolbarView::Init() {
back_ = new BackButton(
browser_->profile(), this,
new BackForwardMenuModel(browser_, BackForwardMenuModel::BACKWARD_MENU));
+ back_->set_hide_ink_drop_when_showing_context_menu(false);
back_->set_triggerable_event_flags(
ui::EF_LEFT_MOUSE_BUTTON | ui::EF_MIDDLE_MOUSE_BUTTON);
back_->set_tag(IDC_BACK);
@@ -188,6 +189,7 @@ void ToolbarView::Init() {
forward_ = new ToolbarButton(
browser_->profile(), this,
new BackForwardMenuModel(browser_, BackForwardMenuModel::FORWARD_MENU));
+ forward_->set_hide_ink_drop_when_showing_context_menu(false);
forward_->set_triggerable_event_flags(
ui::EF_LEFT_MOUSE_BUTTON | ui::EF_MIDDLE_MOUSE_BUTTON);
forward_->set_tag(IDC_FORWARD);
« no previous file with comments | « no previous file | ui/views/controls/button/custom_button.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698