chrome_frame/test/net/fake_external_tab.cc - Issue 19269012: Don't persist HPKP if PrivacyMode is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/test/net/fake_external_tab.cc

Issue 19269012: Don't persist HPKP if PrivacyMode is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address codereview nit and fix compilation error in OFFICIAL_BUILD. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_frame/test/net/fake_external_tab.cc

diff --git a/chrome_frame/test/net/fake_external_tab.cc b/chrome_frame/test/net/fake_external_tab.cc

index bcc779261518a77e110d46a763c918445eb6f621..98787552656b1a5d63242a1307cfed65a6f9c1d7 100644

--- a/chrome_frame/test/net/fake_external_tab.cc

+++ b/chrome_frame/test/net/fake_external_tab.cc

@@ -264,6 +264,7 @@ void FilterDisabledTests() {

// functionality they test (HTTP Strict Transport Security and

// HTTP-based Public Key Pinning) does not work in Chrome Frame anyway.

"URLRequestTestHTTP.ProcessPKP",

+ "URLRequestTestHTTP.ProcessPKP_PrivacyMode",

"URLRequestTestHTTP.ProcessSTS",

"URLRequestTestHTTP.ProcessSTSOnce",

"URLRequestTestHTTP.ProcessSTSAndPKP",