chrome/browser/ui/webui/net_internals/net_internals_ui.cc - Issue 19269012: Don't persist HPKP if PrivacyMode is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/net_internals/net_internals_ui.cc

Issue 19269012: Don't persist HPKP if PrivacyMode is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address codereview nit and fix compilation error in OFFICIAL_BUILD. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/net_internals/net_internals_ui.cc

diff --git a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

index 00a9553de100b18c6f0738b757a8ba9f9fd0f020..306b547e441c8f79b19ab51498cc26af64ff8f53 100644

--- a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

+++ b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc

@@ -1260,7 +1260,7 @@ void NetInternalsMessageHandler::IOThreadImpl::OnHSTSQuery(

} else {

net::TransportSecurityState::DomainState state;

const bool found = transport_security_state->GetDomainState(

- domain, true, &state);

+ domain, true, true, &state);

result->SetBoolean("result", found);

if (found) {